Skip to content

Link to crisp button #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EffreinIBM wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Link to crisp button #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ To run this project locally, complete the following steps:

You can use IBM Cloud Schematics to deploy this Terraform template in the cloud without having a local terraform configuration. Just use this link:

- [Deploy on IBM Cloud](https://cloud.ibm.com/schematics/workspaces/create?repository=https://github.com/Cloud-Schematics/openshift-dev-cluster&terraform_version=terraform_v0.12)
[![Deploy to Kubernetes on {{site.data.keyword.cloud_notm}}](../images/Deploy_to_Openshift.svg "Deploy to Kubernetes on {{site.data.keyword.cloud_notm}}")](https://cloud.ibm.com/schematics/workspaces/create?repository=https://github.com/Cloud-Schematics/openshift-dev-cluster&terraform_version=terraform_v0.12){: external}

@triceam triceam Jul 19, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 things I see here:

  1. This uses a relative URL for the SVG, this should probably be an absolute url. In the readme the image link is broken. If this is being rendered somewhere else, then it's probably broken there too.

    image

  2. The markdown doesn't look quite right. At the beginning there looks like an extra [!, there's a {{site.data.keyword.cloud_notm}} reference, and at the end there's an extra {: external} annotation. Those annotations don't get rendered here on github. Are they supposed to show up somewhere else? Those look consistent with IBM Cloud Docs, which has a separate preprocessing process that they user during publication.z

    image
    image


## Environment variables that use IBMid credentials

Expand Down