Achievements by TheAshSolver · Pull Request #195 · Clubs-Council-IIITH/web

TheAshSolver · 2026-08-06T19:47:48Z

📝 Description

Have added UI features to support adding and viewing achievements.

🚀 Type of Change

Please delete options that are not relevant.

✨ New feature (non-breaking change which adds functionality)

🚀 Changes Introduced

Added an achievements form, achievements page and a manage achievements section to add , edit and view the achievements. Have also added UI features to view achievements from the members and clubs page.

Tip

GitHub Copilot Review
@github-copilot review

…r name, content, dateperiod, images, links, type of achievement and club selector

…ons available

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Introduces an “Achievements” feature across public pages, club pages, profiles, and management flows (create/edit/approve/reject/delete), backed by new GraphQL queries/mutations.

Changes:

Added GraphQL queries/mutations and server actions for achievements CRUD + moderation.
Added UI components and pages for listing, viewing, filtering, and managing achievements (including profile/club integrations).
Added image carousel support for achievement images (slick).

Reviewed changes

Copilot reviewed 33 out of 35 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
src/utils/fetchData.jsx	Adds a cached `getAchievement` fetch helper for achievement detail pages.
src/gql/queries/achievements.jsx	Adds achievement GraphQL queries (all/by user/by id/by club).
src/gql/mutations/achievements.jsx	Adds achievement GraphQL mutations (create/edit/delete/approve/reject).
src/components/profile/UserAchievements.jsx	Adds achievements table to the user profile page.
src/components/events/PaginatedEventGrid.jsx	Whitespace-only change.
src/components/achievements/slick-theme.css	Adds local slick theme overrides for the image carousel.
src/components/achievements/UsersTable.jsx	Adds participants table for an achievement details view.
src/components/achievements/ManageAchievementGrid.jsx	Adds wrapper grid component for manage achievements page.
src/components/achievements/ManageAchievementCards.jsx	Adds card list rendering for manage achievements.
src/components/achievements/ManageAchievementCard.jsx	Adds manage card UI with edit navigation.
src/components/achievements/AchievementsGrid.jsx	Adds server component to fetch/render achievements by club.
src/components/achievements/AchievementsForm.jsx	Adds create/edit achievement form UI and submission logic.
src/components/achievements/AchievementsFilter.jsx	Adds filtering UI for achievements listing page.
src/components/achievements/AchievementLinks.jsx	Adds dynamic blog links field array to the form.
src/components/achievements/AchievementImages.jsx	Adds achievement image carousel + fallback placeholder image.
src/components/achievements/AchievementDetails.jsx	Adds the achievement detail view layout.
src/components/achievements/AchievementCards.jsx	Adds cards grid rendering for achievements lists.
src/components/achievements/AchievementCard.jsx	Adds individual achievement card UI.
src/components/achievements/AchievementActions.jsx	Adds approve/reject/delete UI actions with confirm dialogs.
src/app/profile/[id]/page.jsx	Fetches and displays a user’s achievements on their profile.
src/app/manage/achievements/page.jsx	Adds manage achievements landing page (list + pending approvals).
src/app/manage/achievements/new/page.jsx	Adds create achievement page.
src/app/manage/achievements/[id]/page.jsx	Adds manage achievement detail page with moderation actions.
src/app/manage/achievements/[id]/edit/page.jsx	Adds edit achievement page and defaultValue transformation.
src/app/layout.jsx	Imports slick carousel CSS globally.
src/app/clubs/[id]/page.jsx	Integrates achievements section on club detail page.
src/app/achievements/page.jsx	Adds public achievements list + filter behavior.
src/app/achievements/[id]/page.jsx	Adds public achievement detail page + metadata generation.
src/actions/achievements/reject/server_action.jsx	Adds server action to reject achievements.
src/actions/achievements/edit/server_action.jsx	Adds server action to edit achievements.
src/actions/achievements/delete/server_action.jsx	Adds server action to delete achievements.
src/actions/achievements/create/server_action.jsx	Adds server action to create achievements.
src/actions/achievements/approve/server_action.jsx	Adds server action to approve achievements.
src/acl/routes.js	Adds ACL routes for achievements management pages.

Suppressed comments (3)

src/components/profile/UserAchievements.jsx:1

DataGrid expects flex to be a number (or omitted), and getRowHeight to return a number or 'auto'—returning null can cause warnings/incorrect sizing. Additionally, the initial sort is set to field end, which does not appear in the achievement rows shown elsewhere (dateperiod is used instead), so sorting will be ineffective. Use undefined instead of null for optional props and sort on an actual field (or add a derived end value to rows).
src/components/profile/UserAchievements.jsx:1
DataGrid expects flex to be a number (or omitted), and getRowHeight to return a number or 'auto'—returning null can cause warnings/incorrect sizing. Additionally, the initial sort is set to field end, which does not appear in the achievement rows shown elsewhere (dateperiod is used instead), so sorting will be ineffective. Use undefined instead of null for optional props and sort on an actual field (or add a derived end value to rows).
src/utils/fetchData.jsx:1
Two issues here: (1) catch (achievement) is misleading (it’s an error object), and (2) console.log in a shared fetch utility can generate noisy server logs in production. Rename the catch parameter (e.g., error) and remove/guard logging behind a dev check.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+  let data;
+  if (achievements) {
+    data = { data: { achievements } };
+  } else {
+    data = await getClient().query(GET_ACHIEVEMENT_BY_CLUB, {
+      cid,
+      limit: limit || 12,
+    });
+    // console.log(data);
+  }
+
+  return (
+    <AchievementCards
+      achievements={data.data.achievementsByClub}
+      loading={false}
+      noAchievementsMessage="No achievements found."
+    />
+  );


+        <Button
+          loading={loading}
+          variant="contained"
+          onClick={
+             () => handleSubmit((data) =>
+                    onSubmit(data, { shouldSubmit: true }),
+                  )()
+          }
+          size="large"
+          color="primary"
+          fullWidth
+          disabled={disabled}
+        >


IrishBumfuzzle · 2026-08-07T14:55:55Z

@anma07 @TheAshSolver Please take a look at the bot's review message. If they seem legit, then fix them.
Also where is the manage achievements page meant to be navigated from? It is not in the 'Manage' subsection in the sidebar for clubs

…expression' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

…evementsForm

…o achievements

…nging clubs wile users are selected results in error and not clearing

TheAshSolver and others added 14 commits July 23, 2026 00:31

added qpl mutations and queries

f41747f

created a basic outline for new achievements page and added inputs fo…

cc2f7a9

…r name, content, dateperiod, images, links, type of achievement and club selector

add server actions for achievements

dc050b3

handle submit for new achievements

c42a65c

added a separate link component to keep track of multiple links

3bb3ed1

added links to submit button and added user ids selector

ad27ffb

add edit page for achievements

cdf8d92

show achievements on clubs page

55fd115

show achievements on user profile

d49d9f0

add achievements id page and images slider

7a8487b

add achievements page with filtering

0ef9322

fix images for achievements

91d712d

added a manage page for achievements aloong with individual page acti…

a756204

…ons available

add slick-carousel in layout

2684b30

github-advanced-security Bot found potential problems Aug 6, 2026

View reviewed changes

Comment thread src/components/achievements/AchievementLinks.jsx Fixed

IrishBumfuzzle requested a lite review from Copilot August 6, 2026 20:48

Copilot AI reviewed Aug 6, 2026

View reviewed changes

anma07 added 3 commits August 7, 2026 21:08

replace getUsers

72f51be

add manage achievements and fix images

69d7f67

fix users in achievement form

db6527c

github-advanced-security Bot found potential problems Aug 7, 2026

View reviewed changes

Comment thread src/components/achievements/AchievementLinks.jsx Fixed

suggestions and achievement status

84bde19

anma07 force-pushed the achievements branch from 19d09e7 to 84bde19 Compare August 7, 2026 22:52

anma07 and others added 2 commits August 8, 2026 04:24

Potential fix for pull request finding 'CodeQL / Inefficient regular …

4f62895

…expression' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

add reset for clubs

8c0128a

anma07 force-pushed the achievements branch from ced33d2 to 8c0128a Compare August 8, 2026 07:27

IrishBumfuzzle and others added 3 commits August 8, 2026 16:22

feat: restrict club selection and validate member assignments in Achi…

8f06321

…evementsForm

formatting changes

60380e4

wrapping up merge

fe6148f

anma07 and others added 4 commits August 15, 2026 12:29

add external users and venue

01db037

Merge branch 'achievements' of github.com:Clubs-Council-IIITH/web int…

f76ef18

…o achievements

added a way to show previous images in form and also ensured that cha…

003dad9

…nging clubs wile users are selected results in error and not clearing

ui changes and fix users for edit

2964c08

Navigation Menu

Uh oh!

Achievements - #195

Achievements#195
TheAshSolver wants to merge 27 commits into
masterfrom
achievements

TheAshSolver commented Aug 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IrishBumfuzzle commented Aug 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

TheAshSolver commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

🚀 Type of Change

🚀 Changes Introduced

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IrishBumfuzzle commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TheAshSolver commented Aug 6, 2026 •

edited

Loading

IrishBumfuzzle commented Aug 7, 2026 •

edited

Loading