Skip to content

Shell | Show app only on tasks with an app - #3

Merged
felixbeinssen merged 1 commit into
mainfrom
app-button-only-with-app
Nov 4, 2026
Merged

felixbeinssen merged 1 commit into
mainfrom
app-button-only-with-app

Conversation

@felixbeinssen

Copy link
Copy Markdown
Collaborator

The "Show app" button appeared on every task, including tasks that have no app of their own. It was in the page markup with the hidden attribute, but the design system's .button display rule overrides hidden, so the button always showed.

Changes

Functional changes

  • Tasks without their own web app no longer show a "Show app" button in the header; only the agent switcher and Help remain.
  • Tasks that have their own web app show "Show app" before Help, as before.

Header on a task without an app: the agent switcher and Help only

Header on a task with an app: Show app before Help

Technical changes

  • The shell creates the button in setupAppPane, which only runs when the session has an app, instead of revealing a button that was always in the markup.

Testing

  1. Open a task without an app (any task whose agent-sim.json has no app). The header shows the agent switcher and Help, and no app button.
  2. Open a task with "app": { "port": 5173 }. "Show app" appears before Help; selecting it opens the App pane beside the agent and the button reads "Hide app".

The button was in the page markup with the hidden attribute, but the design system's
.button display rule overrides it, so every task showed it.
@felixbeinssen
felixbeinssen marked this pull request as ready for review November 4, 2026 08:19
@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The hidden “Show app” button was removed from the header markup. setupAppPane now creates and configures the app-pane button, then inserts it before the Help button. Setup no longer explicitly unhides the button.

Possibly related PRs

Merge Risk: Minimal · up to 2f0af

No actionable merge-blocking risk remains for this change.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title names the main change: the "Show app" button now appears only on tasks that have an app. The raw summary confirms that setupAppPane creates the button and the markup no longer contains the h…
Description check Passed The description explains the bug: the "Show app" button showed on every task because the design system's .button display rule overrode the hidden attribute. It lists the functional and technical chang…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the "Show app" button now appears only on tasks that have an app. The raw summary confirms that setupAppPane creates the button and the markup no longer contains the hidden button. The title is specific and matches the description and objectives.

Full details: Description check

Explanation

The description explains the bug: the "Show app" button showed on every task because the design system's .button display rule overrode the hidden attribute. It lists the functional and technical changes and gives test steps. It is directly related to the changeset.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: b036ec65-87c8-4149-9420-7afab5e90d85
Commits

Reviewing files that changed from the base of the PR and between 0bbd5f3 and 2f0afed.

Files selected for processing: 2
  • client/app.js
  • client/index.html
Files with no reviewable changes: 1
  • client/index.html

Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

@felixbeinssen
felixbeinssen merged commit d0dd049 into main Nov 4, 2026
2 checks passed
@felixbeinssen
felixbeinssen deleted the app-button-only-with-app branch November 4, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant