Repository navigation
Shell | Show app only on tasks with an app - #3
Conversation
The button was in the page markup with the hidden attribute, but the design system's .button display rule overrides it, so every task showed it.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
The "Show app" button appeared on every task, including tasks that have no app of their own. It was in the page markup with the
hiddenattribute, but the design system's.buttondisplay rule overrideshidden, so the button always showed.Changes
Functional changes
Technical changes
setupAppPane, which only runs when the session has an app, instead of revealing a button that was always in the markup.Testing
agent-sim.jsonhas noapp). The header shows the agent switcher and Help, and no app button."app": { "port": 5173 }. "Show app" appears before Help; selecting it opens the App pane beside the agent and the button reads "Hide app".