Skip to content

feat: Layout related logical CSS props#3267

Open
LinKCoding wants to merge 1 commit intokl-gmt-1451-logical-props--jh-revertfrom
kl-gmt-1516-layout-revert-clean
Open

feat: Layout related logical CSS props#3267
LinKCoding wants to merge 1 commit intokl-gmt-1451-logical-props--jh-revertfrom
kl-gmt-1516-layout-revert-clean

Conversation

@LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented Feb 12, 2026

Overview

  • Add directional property configs for width, minWidth, maxWidth, height, minHeight, maxHeight (e.g., width → inlineSize) and direction
  • Add direction props to layout config
  • Update docs related to layout and typography
  • Update tests to cover both logical and physical property modes

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1516
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to Props/Layout /foundations-system-props-layout--docs page
  2. Read over the new info and check that it makes sense
  3. Check that the new Direction button works and changes from LTR to RTL and vice versa
  4. Go to the Pagination component page, click around and make sure it works as intended
  5. ...
  6. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@nx-cloud
Copy link

nx-cloud bot commented Feb 12, 2026

View your CI Pipeline Execution ↗ for commit fd61167


☁️ Nx Cloud last updated this comment at 2026-02-12 20:03:39 UTC

@LinKCoding LinKCoding changed the base branch from main to kl-gmt-1451-logical-props--jh-revert February 12, 2026 20:03
@codecademydev
Copy link
Collaborator

📬 Published Alpha Packages:

@codecademy/gamut@68.1.0-alpha.ef1032.0
@codecademy/gamut-icons@9.56.0-alpha.ef1032.0
@codecademy/gamut-illustrations@0.58.3-alpha.ef1032.0
@codecademy/gamut-kit@0.6.581-alpha.ef1032.0
@codecademy/gamut-patterns@0.10.22-alpha.ef1032.0
@codecademy/gamut-styles@17.12.0-alpha.ef1032.0
@codecademy/gamut-tests@5.3.0-alpha.ef1032.0
@codecademy/styleguide@79.2.0-alpha.ef1032.0
@codecademy/variance@0.26.0-alpha.ef1032.0

@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.50%. Comparing base (28d8599) to head (fd61167).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                           Coverage Diff                            @@
##           kl-gmt-1451-logical-props--jh-revert    #3267      +/-   ##
========================================================================
+ Coverage                                 89.09%   89.50%   +0.41%     
========================================================================
  Files                                       236      354     +118     
  Lines                                      4309     5088     +779     
  Branches                                   1447     1641     +194     
========================================================================
+ Hits                                       3839     4554     +715     
- Misses                                      462      526      +64     
  Partials                                      8        8              
Flag Coverage Δ
pull-request 89.50% <100.00%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

@LinKCoding LinKCoding marked this pull request as ready for review February 13, 2026 16:02
@LinKCoding LinKCoding requested a review from a team as a code owner February 13, 2026 16:02
@LinKCoding LinKCoding requested review from aresnik11 and jakemhiller and removed request for a team February 13, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants