Skip to content

feat(gamut): selected-row tint, raised table rows and a two-tone ProgressBar label - #63

Draft
dreamwasp wants to merge 28 commits into
cass-gmt-1825-color-componentsfrom
cass-gmt-1825-color-behavior
Draft

dreamwasp wants to merge 28 commits into
cass-gmt-1825-color-componentsfrom
cass-gmt-1825-color-behavior

Conversation

@dreamwasp

Copy link
Copy Markdown
Contributor

Adds the component behavior design's component map asks for that #54's role swap didn't cover. Merge after #54.

What changes

  • List / DataList / DataTable: a selected row gets the state-selected veil over its own fill, and the hover veil stacks on top when it's hovered. Today a selected row only shows its checkbox. DataList's selected rows set the new isSelected row state, and ListRow accepts it directly.
  • Table rows are surface-raised with surface-sunken stripes, instead of transparent with sunken stripes.
  • ProgressBar: at large and xl, the label is two-tone. It's text-inverse where it sits on the bar and text-default where it runs onto the track. A second copy sits on the track under the bar, and the bar clips its own copy, so a short bar's label doesn't vanish into the track.

Design's map (gamut-styles colorSystem/migration.ts, from sandbox df33b47):

  • List: "Hover and selection are veils, and selected rows get a tint they lack today."
  • ProgressBar: "The label is two-tone: text-inverse where it sits on the bar, text-default where it sits on the track."

Testing

  • New tests cover the selected-row veil (DataGrid) and the two-tone label (ProgressBar).
  • gamut: 1600 of 1600 tests pass. gamut builds, and tsconfig.lib.json typechecks clean.

🤖 Generated with Claude Code

…ressBar label

Behavior design's component map (sandbox df33b47) adds on top of the
role swap in #54:

- List: an `isSelected` row state draws the `state-selected` veil over the
  row's fill, stacked under the hover veil; DataList's selected rows set
  it. Table rows are `surface-raised` instead of transparent.
- ProgressBar: at large and xl, a second copy of the label sits on the
  track in `text-default` and the bar clips its `text-inverse` copy, so a
  label crossing the bar edge reads on both sides.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
…into cass-gmt-1825-color-behavior

# Conflicts:
#	.changeset/color-system-brands.md
#	packages/gamut-styles/src/themes/__tests__/__snapshots__/theme.test.ts.snap
#	packages/gamut-styles/src/themes/__tests__/theme.test.ts
dreamwasp and others added 13 commits November 13, 2026 10:54
Roboto 500 and 700 share one bold file, so the preload list had two links
with the same key (the file URL), and React warned about duplicate keys.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
The skill triaged scope-swap only. Add a color-roles section: the dry-run and
real-run steps, what the warnings and color-roles: comments mean and what to
do for each, the checks before calling it done, and what not to do. The
description names the preset so the skill triggers on color-name work.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
(cherry picked from commit 6f0e3de)
…on and cover every preset

The skill covered scope-swap only. It's now gamut-migration: a presets table,
one workflow for all presets, a section per preset (scope-swap, color-roles),
and a section on documenting a new preset. Renames the changeset to match.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
(cherry picked from commit f5bf30b)
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
(cherry picked from commit 15c7699)
…section

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
(cherry picked from commit 80522ce)
…ion skill

- next-config: removing esmExternals: false is necessary but not always enough. Build each app and fix the routes that still fail at prerender.
- CI: the job that runs sync-gamut-deps fails too, so change it with the script.
- resolutions: yarn why can list two lock locators after a pin, with one copy installed. Check node_modules.
- tsconfig-dom: the codemod warns only where gamut is imported.
- Missing peers: @vidstack/react, react-player and stylis, with the range to add by hand.
- color-roles: a palette name can map to different roles by slot, so use the context in the comment. Keep each app's theme, since the choice changes the spacing scale.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
(cherry picked from commit a0f18dc)
…gration skill

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
(cherry picked from commit bb684b9)
…igration skill

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
(cherry picked from commit b35dc09)
… skill

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
(cherry picked from commit 552d148)
…ser in the gamut-migration skill

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
(cherry picked from commit 7d92c95)
…ate-stylis symptom

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
(cherry picked from commit 0dc47cf)
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
(cherry picked from commit 53cce61)
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
dreamwasp added a commit that referenced this pull request Nov 20, 2026
Replaces this branch's tree with the color stack as it now stands: the
site branch (#67, which includes #63, #59, #54, #66, #58, #52 and #50,
each merged with main through 45586df), plus the codemod branch (#53).
Static styles (#69) is still out, as before.

The preview's earlier head is the parent. This commit only moves the
tree forward, so nothing is rewritten.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
# Conflicts:
#	packages/gamut/src/Anchor/Anchor.stories.tsx
#	packages/gamut/src/Disclosure/Disclosure.stories.tsx
#	packages/gamut/src/Form/inputs/SelectDropdown/SelectDropdown.stories.tsx
#	packages/gamut/src/Tips/PreviewTip/PreviewTip.stories.tsx
@pkg-pr-new

pkg-pr-new Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@skillsoft/eslint-plugin-gamut

npm i https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/eslint-plugin-gamut@63
yarn add https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/eslint-plugin-gamut@63.tgz

@skillsoft/gamut

npm i https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut@63
yarn add https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut@63.tgz

@skillsoft/gamut-agent-tools

npm i https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-agent-tools@63
yarn add https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-agent-tools@63.tgz

@skillsoft/gamut-brand

npm i https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-brand@63
yarn add https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-brand@63.tgz

@skillsoft/gamut-codemods

npm i https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-codemods@63
yarn add https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-codemods@63.tgz

@skillsoft/gamut-icons

npm i https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-icons@63
yarn add https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-icons@63.tgz

@skillsoft/gamut-illustrations

npm i https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-illustrations@63
yarn add https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-illustrations@63.tgz

@skillsoft/gamut-patterns

npm i https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-patterns@63
yarn add https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-patterns@63.tgz

@skillsoft/gamut-styles

npm i https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-styles@63
yarn add https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-styles@63.tgz

@skillsoft/gamut-tests

npm i https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-tests@63
yarn add https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-tests@63.tgz

@skillsoft/variance

npm i https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/variance@63
yarn add https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/variance@63.tgz

commit: 64e6a1a

dreamwasp and others added 3 commits November 20, 2026 11:39
…pies

The label is drawn on the track and on the bar, both aria-hidden. The story checks
both copies rather than one, so it matches the component.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.46%. Comparing base (beb4cff) to head (64e6a1a).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                        Coverage Diff                         @@
##           cass-gmt-1825-color-components      #63      +/-   ##
==================================================================
+ Coverage                           82.07%   83.46%   +1.38%     
==================================================================
  Files                                 490      490              
  Lines                               40121    40152      +31     
  Branches                             1848     1973     +125     
==================================================================
+ Hits                                32929    33511     +582     
+ Misses                               7185     6634     -551     
  Partials                                7        7              
Flag Coverage Δ
pull-request 83.46% <100.00%> (+1.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant