Refactor path search around Pareto fronts - #1123
Open
isPANN wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The previous path contract collapsed named
ProblemSizecomponents into a scalar total, treated symbolic analysis failure as an orderable growth result, and exposed implicit single-route winners through cost functions, top-levelpathoutput, and automatic reduction routing. That could discard incomparable measured vectors, recommend an unanalyzable route, and execute an arbitrary representative from a Pareto front.Contract replacement
Growth::Unknownroutes from the Pareto front while returning each excluded route with its fields and analysis-failure reason.NoAnalyzablePath; incomplete bounded searches remain explicitly incomplete.ProblemSizevectors componentwise, removes dominated vectors, preserves incomparable vectors, and deterministically deduplicates only equal vectors by hops and stable path order.ProblemSize::total(), scalar cost/ranking APIs, and sum-based default budgets are deleted.reducerequires one explicit continuous route; there is no top-level recommendation or automatic target routing.Verification
CARGO_BUILD_JOBS=1 cargo test -p problemreductions --lib rules::graph::pareto_tests:: -- --test-threads=1(32 passed)CARGO_BUILD_JOBS=1 cargo test -p problemreductions --lib rules::graph::tests:: -- --test-threads=1(61 passed)CARGO_BUILD_JOBS=1 cargo test -p problemreductions --lib test_reduction_graph:: -- --test-threads=1(49 passed)-D warnings; CLI clippy passed with the existingtool_routerdead-code warning.cargo fmt --all -- --checkandgit diff --checkpassed.Tests were intentionally focused; no heavyweight workspace coverage or large path enumeration was run. Builds used
CARGO_BUILD_JOBS=1and tests used one thread.Explicitly not implemented
This PR does not provide a scalar recommendation, weights/priorities/constraint-based route selection, a compatibility or deprecated winner API, memory/byte estimates, worker isolation, allocation metadata, or new resource fields. Callers must choose a Pareto-front route explicitly.
This is a stacked PR based on
1075-growth-domain; it must not be merged independently of that base.