Fix the scroll issue on focus cell #13299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GulsahKose
force-pushed
the
focuscellscroll
branch
from
51a7e08 to
39a1d93
Compare
GulsahKose
force-pushed
the
focuscellscroll
branch
from
39a1d93 to
5421c64
Compare
gokaysatir
reviewed
Nov 13, 2025
| zIndex: number; | ||
| interactable: boolean = true; | ||
| isAnimating: boolean = false; | ||
| isAlwaysVisible: boolean = true; |
Contributor
There was a problem hiding this comment.
I will most probably approve this after testing. But before that, can you please set this default to false?
Thanks for the improvements :)
Contributor
Author
There was a problem hiding this comment.
Thanks @caolanm and @gokaysatir for the help
We made the focus cell section always visible. Signed-off-by: Gülşah Köse <[email protected]> Change-Id: I58cdc19c79210ecc1e925c8efd0b3313b68823ef
GulsahKose
force-pushed
the
focuscellscroll
branch
from
5421c64 to
6b5a523
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Section size was wrong so when we scroll the sheet section seems out of visible area.
In this patch we are using the actaul section size.
Change-Id: I58cdc19c79210ecc1e925c8efd0b3313b68823ef
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay