Skip to content

Conversation

@TudorGR
Copy link

@TudorGR TudorGR commented Nov 1, 2025

Summary

This PR ensures all .cpp/.hpp files have consistent editor modelines (Emacs at top, Vim at end), as specified in issue #13329.

Changes made:

  • Added Emacs modeline at top for files that were missing it:

    • clang/plugin.cpp
    • clang/test/capture.cpp
    • clang/test/refcounting.cpp
  • Fixed Emacs modeline (changed Mode: C to Mode: C++) for:

    • common/CoolMount.cpp
    • tools/map.cpp
    • tools/mount.cpp
  • Added both Emacs (top) and Vim (bottom) modelines for:

    • wsd/PlatformDesktop.hpp
    • wsd/PlatformMobile.hpp
    • wsd/PlatformUnix.hpp
    • wsd/SslConfig.hpp

All modelines now follow the standard format:

  • Emacs: /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
  • Vim: /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

TODO

  • Add missing Emacs modelines
  • Fix incorrect Mode: C to Mode: C++
  • Add missing Vim modelines

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Tudor Gradinaru <[email protected]>
Change-Id: I200ed939d19dc3fcae7053e7458cf4101775eeec
@welcome
Copy link

welcome bot commented Nov 1, 2025

Thanks for opening this pull request!

Things that will help get your PR across the finish line:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Review

Development

Successfully merging this pull request may close these issues.

Make mode lines consistent in .cpp/.hpp files (add Emacs at top, Vim at end)

1 participant