Scrollbar: prevent double scrollbar in listbox #13373
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Changed max-height from fixed 470px to min(470px, 45vh) to ensure the listbox container adapts to viewport size. This prevents the double scrollbar issue that occurred when container height was less than max-height, as the responsive constraint ensures proper overflow behavior across different screen sizes. Signed-off-by: Banobe Pascal <[email protected]> Change-Id: Ie7e0a08394c2c89955b4a9c60c89c25bfb32cdf7
pedropintosilva
requested review from
Darshan-upadhyay1110
and removed request for
pedropintosilva
Contributor
Darshan-upadhyay1110
approved these changes
Nov 12, 2025
Contributor
Darshan-upadhyay1110
left a comment
Darshan-upadhyay1110
left a comment
There was a problem hiding this comment.
Tested with different list box and looks good. Thanks Banobe
Darshan-upadhyay1110
deleted the
private/banobepascal/listbox-scrollbars
branch
Contributor
|
@banobepascal can you please backport this change ? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ic8a276feb80e05dd2b31f6b1d6f65d42e1c2719e
Summary
PREVIEW
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay