1st changes for SmartArt UI in cool

[alalg]

Change-Id: I81da386de7e8ee3e66104c80122a025322a9d2db

• Target version: master

Summary

For now reacts if you have a SmartArt in the loaded file

• when selected shows frame around it
• click on frame opens DiagramDialog to edit it

TODO

• Add button on frame to better show that/how edit is done

Checklist

• I have run make prettier-write and formatted the code.
• All commits have Change-Id
• I have run tests with make check
• I have issued make run and manually verified that everything looks okay
• Documentation (manuals or wiki) has been updated or is not required

[welcome]

Thanks for opening this pull request!

Things that will help get your PR across the finish line:

• Check out our contributing guidelines.
• Connect with us through one of our communication channels.
• Click on the details link next to the failing CI checks, if any, to see an explanation on how to fix it.
• Feel free to ping @Darshan-upadhyay1110 or the mentor of the easyHack you are solving if you need help. CC: @pedropintosilva
• Explore more Easy Hacks to dive deeper into Collabora Online and start contributing:https://github.com/CollaboraOnline/online/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22Easy%20Hack%22

[alalg]

NOTES:

• You will need commit 740753639028e037f738e2123d3584609ca85774 which i just added to distro/collabora/co-25.04
• see https://gerrit.libreoffice.org/c/core/+/193494

Without that you will not see anything new :-/

What the change adds:

• when selecting a SmartArt a 'frame' to visualize that is shown around the object (like in LO)
• that frame scales & moves with the object
• the object itself can still be dragged (was hard: that frame covers the object, but needed to have a 'hole')
• clicking on the frame (anywhere) and only on the frame will bring up the DiagramDialog
• in that dialog you can select the node by selecting the text in the listbox
• you can trigger remove event -> that is in LO, thus works partially, is known to need improvement
• in the textbox in the dialog you can add new text & trigger add button -> does not work in core, will need fix there

The goal is to get to what LO can do/offers currently, mainly to have UI in cool to at least do the same as in core.
Yes, not too much works in core yet, that's known and will need work.

[gokaysatir]

@alalg i cannot open the documents. Do i need anything else other than below commit?

• https://gerrit.libreoffice.org/c/core/+/193494

[alalg]

Another question: What can I do for the two 'failed' checks?
I looked at them, but:

• 2nd has no hints at all -> what to do?!?

• 1st one has a hint for diverging screenshots (https://cpci.cbg.collabora.co.uk:8080/job/github_online_master_debug_vs_co-25.04_cypress_desktop/5480/consoleFull#1017170019483a664b-2b8b-4190-95dc-ecb5f3170865), but I cannot look at that screenshots (there are filenames with paths somewhere I cannot access), so how can I get a clue what it thinks is different?

Maybe it's just the new 'frame' being shown, so the test may need change?
Can I execute that test locally somehow separate and see that screenshots?

[gokaysatir]

Another question: What can I do for the two 'failed' checks? I looked at them, but:

* 2nd has no hints at all -> what to do?!?

* 1st one has a hint for diverging screenshots (https://cpci.cbg.collabora.co.uk:8080/job/github_online_master_debug_vs_co-25.04_cypress_desktop/5480/consoleFull#1017170019483a664b-2b8b-4190-95dc-ecb5f3170865), but I cannot look at that screenshots (there are filenames with paths somewhere I cannot access), so how can I get a clue what it thinks is different?

Maybe it's just the new 'frame' being shown, so the test may need change? Can I execute that test locally somehow separate and see that screenshots?

For the second one, please check below page - the console log of the error:

• https://cpci.cbg.collabora.co.uk:8080/job/github_online_master_debug_vs_co-25.04/5157/console
  I agree that it is difficult to see the error there. Please check the end of the page. There is a duplicate code warning.

For the first one - for running the tests locally:
If a desktop test fails (from your case):

• make -C cypress_test/ check-desktop spec=writer/sidebar_spec.js
  If a mobile test failes:
• make -C cypress_test/ check-mobile spec=MyTestPath_spec.js

[alalg]

* https://cpci.cbg.collabora.co.uk:8080/job/github_online_master_debug_vs_co-25.04/5157/console
  I agree that it is difficult to see the error there. Please check the end of the page. There is a duplicate code warning.

Indeed containsPoint is in CanvasSectionObject and also in ContentControlDropdownSubSection which is a HTMLObjectSection which is a CanvasSectionObject -> double.

BUT: how can that be and a failing test - I did neither change browser/src/canvas/sections/ContentControlDropdownSubSection.ts nor did I touch containsPoint in browser/src/canvas/CanvasSectionObject.ts - that already existed, I added isHit below that one, that's true...

Both are from gokaysatir:
The one in CanvasSectionObject from last month (Change-Id: I87a478040cf18a7d484d2f04107fc7199bd9e91e)
The one in ContentControlDropdownSubSection 10month ago (Change-Id: Ic13b92b745fc9443b28003969cb8e53f1c42d56b)

[gokaysatir]

* https://cpci.cbg.collabora.co.uk:8080/job/github_online_master_debug_vs_co-25.04/5157/console
  I agree that it is difficult to see the error there. Please check the end of the page. There is a duplicate code warning.

Indeed containsPoint is in CanvasSectionObject and also in ContentControlDropdownSubSection which is a HTMLObjectSection which is a CanvasSectionObject -> double.

BUT: how can that be and a failing test - I did neither change browser/src/canvas/sections/ContentControlDropdownSubSection.ts nor did I touch containsPoint in browser/src/canvas/CanvasSectionObject.ts - that already existed, I added isHit below that one, that's true...

Both are from gokaysatir: The one in CanvasSectionObject from last month (Change-Id: I87a478040cf18a7d484d2f04107fc7199bd9e91e) The one in ContentControlDropdownSubSection 10month ago (Change-Id: Ic13b92b745fc9443b28003969cb8e53f1c42d56b)

That's unfair :) I don't know why it didn't catch the first occurrence.