Skip to content

Stop initializing cvs after atom group init fail#674

Merged
giacomofiorin merged 1 commit intomasterfrom
fix_segfaults
Mar 14, 2024
Merged

Stop initializing cvs after atom group init fail#674
giacomofiorin merged 1 commit intomasterfrom
fix_segfaults

Conversation

@jhenin
Copy link
Copy Markdown
Member

@jhenin jhenin commented Mar 14, 2024

Done only to CVs where it is critical because followed by memory allocation assuming that the atom groups were parsed successfully. This fixes segfaults upon trying to load non-existent atomFiles.

Done only to CVs where it is critical because followed by memory
allocation assuming that the atom groups were parsed successfully.
@giacomofiorin giacomofiorin merged commit 82afedd into master Mar 14, 2024
@giacomofiorin
Copy link
Copy Markdown
Member

Note for future reference: not backporting this bugfix to release branches, because it only applies to the code after #643

@giacomofiorin giacomofiorin deleted the fix_segfaults branch March 14, 2024 17:55
@giacomofiorin giacomofiorin added the bugfix To be used only in PRs label Mar 14, 2024
@giacomofiorin giacomofiorin mentioned this pull request Aug 5, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix To be used only in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants