DX: increase test coverage to 85%#621
Merged
Merged
Conversation
* DX: increase minimal test coverage to 39%
* DX: increase test coverage to 52%
* DX: increase test coverage to 56%
* DX: increase test coverage to 59%
* DX: increase test coverage to 62%
* DX: increase test coverage to 65%
* DX: increase test coverage to 67%
* DX: increase test coverage to 68%
The `fixed_sections` generator indexed `original_config[section_name]`, which raised `KeyError` when the template adds a section absent from the original config (e.g. starting from an empty `.cspell.json`).
* DX: increase test coverage to 70%
* DX: increase test coverage to 72%
* DX: increase test coverage to 81%
* DX: increase test coverage to 83%
Route every sub-step in `ty.main`/`pyright.main` (and their `_update_vscode_settings` helpers) through an `Executor`, as the other check modules already do. Previously the functions called each fallible step directly, so the first `PrecommitError` (e.g. the initial VS Code change) aborted the `with` body and was swallowed by the empty-changelog `ModifiablePyproject` context. That made the config, dependency, and pre-commit updates land only on later runs; they now all apply at once.
f0a8d85 to
0ed6eb9
Compare
* FIX: remove comitted Codex configuration
0ed6eb9 to
7f0cd1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #615
🖱️ Developer experience
pythonchecks (pyproject,ruff,pytest,ty,pyright,black,mypy,pyupgrade), theenv/uv,format(precommit,prettier,toml,cspell),github/workflows,nb/binder,readthedocs, andrepo(poe,citation,commitlint,deprecated) modules, plus thecli,gitpod, andpixichecks.pytest-describefor grouped, readable test blocks, and add it to thetestdependency group.--cov-fail-under=33to85and the Codecovprojecttarget from33%to85%so the new coverage is enforced.branch = falseandbranch-coverage = false) so the gate tracks line coverage only.__has_uv_rundocumenting its behaviour for both string and sequence commands.🐛 Bug fixes
cspell: compare againstoriginal_config.get(section_name)in_update_config_contentso that newly added sections no longer raise aKeyError.pyright/ty: run all configuration updates through a singleExecutorso every update is applied in one pass instead of bailing out on the first reported change.Squash commit messages