N°8892 - feat(Utils): Add method to retrieve module version #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to First review needed
in Combodo PRs dashboard
5 tasks
jf-cbd
changed the title
odain-cbd
reviewed
Nov 24, 2025
odain-cbd
reviewed
Nov 24, 2025
| public static function GetModuleVersion(string $sModuleId, RestClient $oClient = null): string | ||
| { | ||
| if (!isset(static::$aModuleVersions[$sModuleId])) static::CheckModuleInstallation($sModuleId, true, $oClient); | ||
| return static::$aModuleVersions[$sModuleId]; |
Contributor
There was a problem hiding this comment.
what if key i s still missing?
Contributor
There was a problem hiding this comment.
could you also add tests please?
Collaborator
Author
There was a problem hiding this comment.
Sure, but first wanted to know if Combodo would accept this addition.
If the module is not found, an exception will be thrown, so this return statement will not be reached..
Contributor
There was a problem hiding this comment.
current PR was accepted functionnally. I am here to check technical details before merging it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base information
Objective (enhancement)
Helper method to easily get installed version of a module in iTop.
Proposed solution (bug and enhancement)
Added
GetModuleVersionmethod toUtilsclass. In the meantime consecutive calls to theCheckModuleInstallationmethod for the same module will be faster as the result is now cached.Checklist before requesting a review