Add errors for install dir edge cases #6733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benceruleanlu
requested review from
a team,
KarryCharon,
Yorha4D and
shinshin86
as code owners
dosubot
bot
added
the
size:XS
🎭 Playwright Test Results⏰ Completed at: 11/19/2025, 07:00:42 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/19/2025, 06:50:34 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.14 MB (baseline 3.14 MB) • 🔴 +348 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 913 kB (baseline 913 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 8.03 kB (baseline 8.03 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 307 kB (baseline 307 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 130 kB (baseline 130 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 12.6 kB (baseline 12.6 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 5.32 MB (baseline 5.32 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.9 MB (baseline 3.9 MB) • ⚪ 0 BBundles that do not match a named category
Status: 18 added / 18 removed |
Member
Author
|
Waiting for new types from desktop |
dosubot
bot
added
size:S
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
christian-byrne
approved these changes
Nov 19, 2025
benceruleanlu
added
the
needs-backport
Member
Author
|
Going to backport this to 1.32, 1.31, and 1.30 for next desktop release, planning to use frontend 1.30. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 19, 2025
## Summary - show explicit validation errors when the install path lives inside the desktop app bundle or updater cache - include the new locale strings for these error prompts so the UI surfaces actionable guidance ## Testing - pnpm typecheck - pnpm lint:fix ## Notes Desktop types still need to be updated to include the new validation flags; see Comfy-Org/desktop#1400 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6733-Add-errors-for-install-dir-edge-cases-2af6d73d3650811bada6fc7dd72ecf68) by [Unito](https://www.unito.io)
|
@benceruleanlu Backport to Please manually cherry-pick commit Conflicting files
|
benceruleanlu
added a commit
that referenced
this pull request
Nov 20, 2025
## Summary - show explicit validation errors when the install path lives inside the desktop app bundle or updater cache - include the new locale strings for these error prompts so the UI surfaces actionable guidance ## Testing - pnpm typecheck - pnpm lint:fix ## Notes Desktop types still need to be updated to include the new validation flags; see Comfy-Org/desktop#1400 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6733-Add-errors-for-install-dir-edge-cases-2af6d73d3650811bada6fc7dd72ecf68) by [Unito](https://www.unito.io)
benceruleanlu
added a commit
that referenced
this pull request
Nov 20, 2025
- show explicit validation errors when the install path lives inside the desktop app bundle or updater cache - include the new locale strings for these error prompts so the UI surfaces actionable guidance - pnpm typecheck - pnpm lint:fix Desktop types still need to be updated to include the new validation flags; see Comfy-Org/desktop#1400 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6733-Add-errors-for-install-dir-edge-cases-2af6d73d3650811bada6fc7dd72ecf68) by [Unito](https://www.unito.io)
benceruleanlu
added a commit
that referenced
this pull request
Nov 20, 2025
## Summary - show explicit validation errors when the install path lives inside the desktop app bundle or updater cache - include the new locale strings for these error prompts so the UI surfaces actionable guidance ## Testing - pnpm typecheck - pnpm lint:fix ## Notes Desktop types still need to be updated to include the new validation flags; see Comfy-Org/desktop#1400 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6733-Add-errors-for-install-dir-edge-cases-2af6d73d3650811bada6fc7dd72ecf68) by [Unito](https://www.unito.io)
christian-byrne
pushed a commit
that referenced
this pull request
Nov 20, 2025
Backport of these two PRs: #6733 #6750 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6761-Fix-desktop-update-issues-2b16d73d3650817fad89d402d39cf9a0) by [Unito](https://www.unito.io)
christian-byrne
pushed a commit
that referenced
this pull request
Nov 20, 2025
Backport of these two PRs: #6733 #6750 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6760-Backport-desktop-update-issues-2b16d73d365081dfb733ca68e3c5a8bc) by [Unito](https://www.unito.io)
christian-byrne
pushed a commit
that referenced
this pull request
Nov 20, 2025
Backport of these two PRs: #6733 #6750 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6759-Backport-desktop-update-issue-2b16d73d36508182b91cdbb123418783) by [Unito](https://www.unito.io)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Notes
Desktop types still need to be updated to include the new validation flags; see Comfy-Org/desktop#1400
┆Issue is synchronized with this Notion page by Unito