Add shape support to VectorParam (fixes #58)#59
Merged
rbouckaert merged 1 commit intomasterfrom Apr 7, 2026
Merged
Conversation
Add optional shape input to KeyVectorParam that allows flat vector storage to be interpreted as a multi-dimensional array. When shape is set (e.g. shape="3 4" for a 3x4 matrix), rank() and shape() reflect the tensor dimensions, and get(int... idx) supports multi-dimensional indexing via row-major strides. Wired up in both RealVectorParam and IntVectorParam. Backward compatible: vectors without shape behave exactly as before. Replaces the deprecated minordimension on Parameter.Base.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shapeinput toKeyVectorParamthat allows flat vector storage to be interpreted as a multi-dimensional array (e.g.shape="3 4"for a 3x4 matrix)rank()andshape()reflect the tensor dimensions;get(int... idx)supports multi-dimensional indexing via row-major stridesRealVectorParamandIntVectorParamminordimensiononParameter.Basenrows(),ncols()for the common 2D caseTest plan
RealVectorParamTest: basic 3x4 matrix indexing, default (no shape), shape/dimension mismatch, wrong index countCloses #58