check_dns: ai commit, add --attempts support - #463
Merged
Merged
Conversation
it uses the same dns connection throught, but sends multiple packets if the proceeding packets do not get an answer. it uses connections WriteMsg, SetReadDeadline to add timeouts and ReadMsg with with error checks to see if timeouts were met. timeout and attemps are now also read from resolv.conf if defined. attemps divide the query timeout into equal per UDP message timeouts. this is implemented in the new exchangeWithRetries function all combinations between hostCandidate x nameserver are checked using exchangeWithRetries function now instead of previous c.ExhangeContext
sni
reviewed
Sep 10, 2026
additionally fix German ist -> is in CriticalTimeout text
sni
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it uses the same dns connection throught, but sends multiple packets if the proceeding packets do not get an answer. it uses connections WriteMsg, SetReadDeadline to add timeouts and ReadMsg with with error checks to see if timeouts were met.
timeout and attemps are now also read from resolv.conf if defined. attemps divide the query timeout into equal per UDP message timeouts.
this is implemented in the new exchangeWithRetries function
all combinations between hostCandidate x nameserver are checked using exchangeWithRetries function now instead of previous c.ExhangeContext