Repository navigation
Pin useful_abstractions to v0.1.0; clone it without credentials in CI - #40
Merged
Merged
Conversation
…#28) The dependency was private when #28 was filed, so FetchContent failed for everyone outside the organization. CI didn't notice because every workflow rewrote github.com URLs to use an access token. The repository is public now, so the token steps go: CI clones the way users do. FetchContent also tracked `master`, so each perfect_hash release fetched whatever the dependency's branch held at configure time. Pin to the v0.1.0 release (its headers are identical to today's master, and the amalgamated single header is byte-for-byte unchanged). amalgamate.py --fetch clones the same tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28.
When #28 was filed,
ConstexprCore/useful_abstractionswas private, so the FetchContent clone failed for anyone outside the organization. It's public now and an anonymous clone works, but two things let the problem happen and would let it come back:https://github.com/to useUSEFUL_ABSTRACTIONS_PAT, so CI could never see a clone failure that users would hit. Those steps are removed fromci.yml(matrix, Fil-C and single-header jobs),loongarch64.ymlandrelease.yml.master. Every perfect_hash release, old ones included, fetched whatever that branch held at configure time.CMakeLists.txtnow pins thev0.1.0tag (shallow clone), andsingleheader/amalgamate.py --fetchclones the same tag. A comment inCMakeLists.txtsays to keep the two in sync.v0.1.0's headers are identical to today'smaster(the commits after the tag only touch docs), so nothing changes for the library.Checked with no git credentials (
GIT_CONFIG_GLOBAL=/dev/null GIT_CONFIG_NOSYSTEM=1 GIT_TERMINAL_PROMPT=0):v0.1.0(fae9101), and all 80 tests pass;amalgamate.py --checksays the single header is up to date: it is byte-for-byte the same;amalgamate.py --fetchclonesv0.1.0.