Skip to content

Add lesson: proposal-ships-the-working-fix - #45

Merged
jeremymanning merged 2 commits into
mainfrom
compound/lesson-proposal-ships-the-working-fix
Oct 22, 2026
Merged

jeremymanning merged 2 commits into
mainfrom
compound/lesson-proposal-ships-the-working-fix

Conversation

@jeremymanning

Copy link
Copy Markdown
Member

Proposes the lesson proposal-ships-the-working-fix for the general pool.

When it applies: Use when proposing a fix upstream or to a shared pool (compound promote --to general, a pull request to a tool's repository) after solving the problem locally, and when asked to generalize, package or share something that works on this machine.

Files:

  • lessons/proposal-ships-the-working-fix/SKILL.md

The text:

Propose the thing that works, in the form that works. Before opening the upstream pull
request, put the local fix and the proposal side by side and name every difference; each
one is either removed or justified in the pull request.

The wrong way: the local fix is a hook that refuses a stop, and the upstream proposal is a
lesson that says to run a script by hand. The advice form depends on the reader remembering
it, which is the failure the hook existed to remove, so the proposal does not solve the
problem it describes. The same drift shows up as a guard proposed as a plain lesson, an
enforced check proposed as documentation, or a narrowed, tested script proposed in its
earlier, looser draft.

If the working form cannot ship as it is (the host has no hook mechanism, the script is
specific to one machine), say so in the pull request and propose the nearest enforced
form, not a reminder. When the local fix changes after the proposal is open, update the
proposal in the same sitting: the shipped file should be byte-identical to the one in use
(`cmp local upstream`).

jeremymanning and others added 2 commits October 10, 2026 18:43
A lesson added to the pool has to appear in the README table, the design table,
the counts beside them and the SHIPPED expectations, or test_docs and
test_general_pool fail. The promote command adds only the lesson's own files.

run_tests.sh: OK, 23 files.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V7QkYvK7jaE1QVY1ZMfAt2
@jeremymanning
jeremymanning merged commit 2cc79a5 into main Oct 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant