feat(editor): add keyboard shortcut for Run Code button#8268
Open
enkr1 wants to merge 1 commit intoCoursemology:masterfrom
Open
feat(editor): add keyboard shortcut for Run Code button#8268enkr1 wants to merge 1 commit intoCoursemology:masterfrom
enkr1 wants to merge 1 commit intoCoursemology:masterfrom
Conversation
Author
|
Friendly ping — this is a small one (Ctrl+Shift+Enter for Run Code, mirroring the existing Ctrl+Enter for Submit). The shortcut choice avoids collisions with the existing submit binding. Happy to tweak the key combo if the team has a preference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4972
Changes
RunCodeButton.tsx:Ctrl+Shift+Enter/Cmd+Shift+Enterkeyboard shortcut (mirrorsSubmitButtonpattern usingreact-hot-keys)isDisabledto avoid duplicating the conditiontranslations.ts:runCodeTooltiptranslationWhy
Ctrl+Shift+Enter?Ctrl+Enteris already used by Submit.Shiftmodifier keeps it distinct while staying intuitive — same pattern used in VS Code for "Run" vs "Run Selection".Not changed
Submit button's existing
Ctrl+Entershortcut is untouched.