Skip to content

autoclaim compat + issue fix + displaying territory's name upon entering it#18

Open
starpanda24825 wants to merge 5 commits into
Create-Civilization:1.21.1-rcfrom
starpanda24825:1.21.1-rc
Open

autoclaim compat + issue fix + displaying territory's name upon entering it#18
starpanda24825 wants to merge 5 commits into
Create-Civilization:1.21.1-rcfrom
starpanda24825:1.21.1-rc

Conversation

@starpanda24825
Copy link
Copy Markdown
Contributor

  • Made compatibility with jm UI for Ko1Bo1's autoclaim command
  • Fixed client-side claims display/persistance issue, where the JourneyMap overlay was not reliably rebuilding from the persisted server-side jm claims file on restart, resultig in territories being owned by player but not appearing on map.
  • Implemented territory entry text above the hotbar: when entering a player's territory the name of team gets displayed in the team's colour, when exiting into an unclaimed chunk the text says "Wilderness" in green.

Copy link
Copy Markdown
Contributor

@EpicVon2468 EpicVon2468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some pedantic notes

Comment thread src/main/java/com/createcivilization/capitol/client/events/ChunkEvents.java Outdated
Comment thread src/main/java/com/createcivilization/capitol/client/events/ChunkEvents.java Outdated
Comment thread src/main/java/com/createcivilization/capitol/client/events/ChunkEvents.java Outdated
Comment thread src/main/java/com/createcivilization/capitol/client/events/ChunkEvents.java Outdated
}

@SubscribeEvent
private static void onClientTick(ClientTickEvent.Post event) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole way of displaying claim entering is not how I personally wanna go about it. Its like how every other claim mod does it. Hard to explain how I would do it but I do have plans for it. I will get to it after my finals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants