fix(ingestion): ensure replay idempotency and deterministic dedup - #1304
Open
Nwoyemartha wants to merge 1 commit into
Open
Nwoyemartha wants to merge 1 commit into
Nwoyemartha wants to merge 1 commit into
Conversation
Implements durable replay safety and idempotency for Horizon ingestion and reconciliation (issue CredenceOrg#1261): - SorobanClient: integrate SingleFlight into callRpc() with deterministic operation fingerprinting (SHA-256 of method + canonical JSON params) to coalesce concurrent and retried RPC calls into a single round-trip. - horizonBondEvents: add conflicting event detection via resolveConflictingEvent() and ConflictingEventError — when the same event ID arrives with a materially different payload, it is rejected deterministically. Identical replays are safe no-ops that skip business logic but still advance the cursor. - ReplayService: wrap each event replay in IdempotentConsumer to prevent duplicate business effects when replayLedgerRange() is re-run after a crash. - Add canonicalJson() for deterministic, key-order-independent fingerprinting. - Add throwIfCancelled() to SorobanClient for abort-signal fail-fast. Correctness invariants: - Same logical request can be retried safely (SingleFlight coalesces). - Duplicate processing results in one committed business effect. - Conflicting request-key reuse is rejected (ConflictingEventError). - Failed/rejected operations leave no unauthorized partial state. - Replay/reordering converges to authoritative state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements durable replay safety and idempotency for Horizon ingestion and reconciliation (issue #1261):
Correctness invariants: