Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds optimistic UI feedback to the AmountInput primary action (Continue button). When
isSubmittingis true:PendingButtoncomponentaria-busy="true"for screen reader announcementsdisabled:opacity-40 disabled:cursor-not-allowed) applied consistentlyThe revert-on-failure pattern is handled by the parent component — the parent sets
isSubmitting=falseon error, which restores the normal Continue button and re-enables all inputs.Changes
AmountInput.tsx: AddedisSubmittingprop, integratedPendingButton, disabled all interactive elements when submittingAmountInput.test.tsx: Added 5 tests covering spinner display, label swap, disabled state, andaria-busybehaviorCloses #853