fix(container-pull): add missing account param in registry token URL#497
Merged
Merged
Conversation
The /v2/token endpoint URL was missing the `account` query parameter name, producing `?=username` instead of `?account=username`. The laggar registry (us-gov-1) rejects this malformed URL with a 500 error while commercial registries silently ignore it.
skasianov
approved these changes
May 21, 2026
redhatrises
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/v2/tokenendpoint URL infetch_tags()was missing theaccountquery parameter name, producing?=usernameinstead of?account=username. The laggar registry (us-gov-1) started rejecting this malformed URL with a 500 error — commercial registries still tolerate it, but the URL was never spec-correct.Tested against both
registry.laggar.gcw.crowdstrike.comandregistry.crowdstrike.comto confirm the fix works on gov and commercial.