Skip to content

Fix biomes for igloos and mansions #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xpple wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix biomes for igloos and mansions #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e3695e
Fix biomes for igloos and mansions
xpple Apr 10, 2025
3aaf7d1
Add back Snowy Tundra (old biome)
xpple Apr 10, 2025
eeae66c
Add version check for mansions
xpple Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion biomes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ enum MCVersion
MC_1_21_1,
MC_1_21_3,
MC_1_21_WD, // Winter Drop, version TBA
MC_1_21 = MC_1_21_WD,
MC_1_21_5,
MC_1_21 = MC_1_21_5,
MC_NEWEST = MC_1_21,
};

Expand Down
5 changes: 3 additions & 2 deletions finders.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1195,7 +1195,8 @@ int isViableFeatureBiome(int mc, int structureType, int biomeID)

case Igloo:
if (mc <= MC_1_8) return 0;
return biomeID == snowy_tundra || biomeID == snowy_taiga || biomeID == snowy_slopes;
return (biomeID == snowy_tundra || biomeID == snowy_taiga
|| biomeID == snowy_plains || biomeID == snowy_slopes);

case Ocean_Ruin:
if (mc <= MC_1_12) return 0;
Expand Down Expand Up @@ -1282,7 +1283,7 @@ int isViableFeatureBiome(int mc, int structureType, int biomeID)

case Mansion:
if (mc <= MC_1_10) return 0;
return biomeID == dark_forest || biomeID == dark_forest_hills;
return biomeID == dark_forest || biomeID == dark_forest_hills || (mc >= MC_1_21_5 && biomeID == pale_garden);

case Fortress:
return (biomeID == nether_wastes || biomeID == soul_sand_valley ||
Expand Down