Add game tests for all mod advancements#194
Merged
rubensworks merged 2 commits intomaster-1.21-ltsfrom Feb 28, 2026
Merged
Conversation
Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement game tests for all advancements in mod
Add game tests for all mod advancements
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements game tests to verify all advancements in ColossalChests can be obtained through the correct in-game mechanics as defined by their advancement JSON files.
New Tests (16 total)
testAdvancementRoot— firesINVENTORY_CHANGEDtrigger with a chest itemtestAdvancementUncolossal—ServerPlayerplaces uncolossal chest, triggeringplaced_blocktestAdvancementBase{Material}× 7 — builds a 2×2 chest with one wall missing,ServerPlayerplaces the final wall block, completing the chest and firingchest_formedtestAdvancementSize{Material}× 7 — same pattern but with a 10×10×10 chest (filling the existingempty10template), satisfyingminimumSize: 10New Helpers
All tests exercise the real trigger chain — placing a block as a
ServerPlayergoes throughBlockItem.place()→setPlacedBy()→triggerDetector()→ criterion trigger → advancement grant — rather than firing triggers directly.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
maven.fabricmc.net/opt/hostedtoolcache/Java_Microsoft_jdk/21.0.2/x64/bin/java /opt/hostedtoolcache/Java_Microsoft_jdk/21.0.2/x64/bin/java --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED -Xmx3G -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.8-bin/dl7vupf4psengwqhwktix4v1/gradle-8.8/lib/gradle-launcher-8.8.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.8-bin/dl7vupf4psengwqhwktix4v1/gradle-8.8/lib/agents/gradle-instrumentation-agent-8.8.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.8 vupf4psengwqhwktix4v1/gradle-8.8/lib/agents/gradle-instrumentation-agent-8.8.jar 0/steps/unzipSources/unpacked/net/minecraft/tags/FluidTags.java(dns block)If you need me to access, download, or install something from one of these locations, you can either:
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.