Add negative game tests for all advancements#1161
Merged
rubensworks merged 2 commits intomaster-1.21-ltsfrom Feb 28, 2026
Merged
Add negative game tests for all advancements#1161rubensworks merged 2 commits intomaster-1.21-ltsfrom
rubensworks merged 2 commits intomaster-1.21-ltsfrom
Conversation
Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add negative game tests for all advancements
Add negative game tests for all advancements
Feb 28, 2026
Pull Request Test Coverage Report for Build 22525617793Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds negative game tests for all 12 EvilCraft advancements — tests that perform an action almost matching each advancement criterion but not quite — to guard against false-positive triggers.
Changes
assertAdvancementNotDonehelper: throwsGameTestAssertExceptionif an advancement is unexpectedly grantedrootminecraft:dirt(not an EvilCraft item)first_agedirtto inventory (notdark_gem)second_agedark_gem(notblood_extractor)cannibalflesh_werewolf(notflesh_humanoid)closureevil_sourcedark_gemto inventory (notorigins_of_darkness)fartinventory_changed(not the fart trigger)master_distorterplayer_distorterplayer_devastatorpower_craftingdark_gem(notexalted_crafter)spirit_cookerblood_extractor(notspirit_furnace)The
master_distorterandplayer_distorternegative tests callTRIGGER_DISTORT.get().test(player, entities)directly rather than going through the mace physics, sincereleaseUsingwithitemInUseCount=0produces a 102-block AABB that can capture mock players from concurrent test structures.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.