Skip to content

Migrate shadow plugin from com.github.johnrengelman to com.gradleup#60

Merged
rubensworks merged 3 commits intomaster-1.20-ltsfrom
copilot/fix-build-migrate-to-shadow-plugin
Mar 9, 2026
Merged

Migrate shadow plugin from com.github.johnrengelman to com.gradleup#60
rubensworks merged 3 commits intomaster-1.20-ltsfrom
copilot/fix-build-migrate-to-shadow-plugin

Conversation

Copy link
Contributor

Copilot AI commented Mar 9, 2026

com.github.johnrengelman.shadow 8.1.1 bundles ASM 9.4, which cannot process Java 21 class files (major version 65), causing shadowJar to fail in CI.

Changes

  • build.gradle: Replace com.github.johnrengelman.shadow:8.1.1 with com.gradleup.shadow:8.3.8 (community-maintained fork; uses ASM 9.7+ with Java 21+ support; API-compatible drop-in replacement)
  • .gitignore: Add /logs to exclude Minecraft runtime logs
Original prompt

Please fix the build by migrating to the new shadow plugin, just like I recently did in the Integrated Dynamics branch in the 1.20-lts branch.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits March 9, 2026 18:55
Copilot AI changed the title [WIP] Fix build by migrating to new shadow plugin Migrate shadow plugin from com.github.johnrengelman to com.gradleup Mar 9, 2026
@rubensworks rubensworks marked this pull request as ready for review March 9, 2026 19:04
@rubensworks rubensworks merged commit b7c5044 into master-1.20-lts Mar 9, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants