Skip to content

Conversation

@mokhld
Copy link
Contributor

@mokhld mokhld commented Jan 16, 2026

…dnance Survey

Proposed change

What:
Adds lowerFirstPreserveProperNouns to preserve capitalisation of "National Grid", "Ordnance Survey", and "OS" when lowerFirst is applied in validation error messages.

Why:
Error messages were displaying "national Grid" instead of "National Grid" in the server-side rendered error preview panel.

Jira ticket:

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Misc. (documentation, build updates, etc)

Checklist

  • You have executed this code locally and it performs as expected.
  • You have added tests to verify your code works.
  • You have added code comments and JSDoc, where appropriate.
  • There is no commented-out code.
  • You have added developer docs in README.md and docs/* (where appropriate, e.g. new features).
  • The tests are passing (npm run test).
  • The linting checks are passing (npm run lint).
  • The code has been formatted (npm run format).

@mokhld mokhld marked this pull request as ready for review January 16, 2026 14:42
@sonarqubecloud
Copy link

Copy link
Contributor

@jbarnsley10 jbarnsley10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mokhld mokhld merged commit ecb2856 into main Jan 16, 2026
24 checks passed
@mokhld mokhld deleted the fix/df-773-national-grid-capitalisation branch January 16, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants