ci: add GitHub Actions workflow (build gate + advisory vet/gofmt/race) - #38
Open
Dirtybird99 wants to merge 1 commit into
Open
ci: add GitHub Actions workflow (build gate + advisory vet/gofmt/race)#38Dirtybird99 wants to merge 1 commit into
Dirtybird99 wants to merge 1 commit into
Conversation
The repository had no CI. This adds a minimal workflow that runs on pushes to the community-* / main branches and on all pull requests. - build (blocking): `go build ./...` — currently green, so it can serve as a required status check to catch compile breakage. - quality (advisory): `go vet ./...`, a gofmt check over non-vendor sources, and `go test -race ./walletapi/...`. Each step is continue-on-error because the tree has pre-existing findings (data races tracked in the walletapi issues, plus vet/gofmt debt). They surface the signal in logs without blocking merges; drop continue-on-error on a step once its debt reaches zero. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Dirtybird99
force-pushed
the
ci/add-github-actions
branch
from
July 11, 2026 19:52
108edc5 to
7749589
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the repository's first CI workflow (
.github/workflows/ci.yml). It runs on pushes tocommunity-dev/community-mainnet/community-testnet/mainand on all pull requests.Two jobs:
go build ./.... This is green on the current tree, so it's safe to make a required status check and will catch compile breakage in future PRs.go vet ./..., agofmtcheck over non-vendor sources, andgo test -race ./walletapi/.... Every step iscontinue-on-error, so the check stays green while the pre-existing findings are burned down; the output still shows in the logs. Dropcontinue-on-errorfrom a step once its debt reaches zero to promote it to a gate.Why
The repo currently has no
.github/workflowsat all. A build gate alone would have caught the concurrent-map crash class discussed in #26, and the race step surfaces thewalletapidata races filed as #33–#37.Verification done before opening this PR
Against
community-dev@6f9bd2c:go build ./...(Windows, go 1.26)GOOS=linux GOARCH=amd64 go build ./...(cross-compile; project has no cgo)go vet ./...gofmt -l(non-vendor tracked.go)go test -race ./walletapi/...sync_loop(daemon_communication.go:217) +xswdrate-limit test — advisory, tracked in #33/#34So the blocking job is verified green on the Linux target; the three currently-red checks are intentionally advisory and each links to tracked debt.
Suggested adoption path
community-dev.continue-on-error.Note
Because this is a first-time contribution, a maintainer may need to approve the workflow run before it executes on this PR. The workflow file itself is minimal and uses only
actions/checkoutandactions/setup-go.