fix: assign network value to get info response - #54
Open
secretnamebasis wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GetInfo's RPC handler only ever assignsresult.Networkinside theglobals.IsSimulator()branch ("Simulator") — there's no corresponding branch for a real mainnet or testnet node, soNetworkis left as an empty string for every non-simulator daemon. This fix adds the missingelse if globals.IsMainnet()/elsebranches so a real node correctly reports"Mainnet"or"Testnet".Directly observed independently: running
get infothrough a wallet client against a live mainnet node returned a completely blankNetwork:field, while every otherGetInfo_Resultfield (height, difficulty, version, etc.) was populated normally — isolating the bug to this one unset field rather than a broader RPC failure.Fixes # (no tracked issue number)
Type of change
Which part is impacted?
Checklist:
License
I am contributing & releasing the code under DERO Research License (which can be found here).