Add Order search filter #1549
Open
Add Order search filter #1549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for-flavor-text Document external TTS usage for flavor-text
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Motivation Prevent deleted work orders from being reinserted into the filtered snapshot while a search filter is active, which could lead to UI actions on stale entries and crashes. Description Track the IDs of the last filtered set in self.last_filtered_ids and compute the current live orders IDs each filter application. When previously-visible orders are missing from the live list, prune those IDs out of self.unfiltered_orders so deleted orders are not re-added. Reset self.last_filtered_ids when restoring the full, unfiltered list in restore_orders.
Added self:drop_deleted_from_snapshot(self:detect_deleted_ids()) I was receiving a crash while troubleshooting. With this change, the crash no longer occurs. Repro steps: Open the work order menu Search: meal Delete Easy Meal and Lavish Meal Exit the work order menu Re-enter the work order menu Search: meal Error: The deleted Easy Meal and Lavish Meal reappear. This is an error. If the user attempts to delete them again or quit, the game crashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
order-search-filter
This overlay adds a small filter field to the Work Orders screen. Typing text filters the existing manager order list so only matching entries remain visible.
Overlay
When the Work Orders screen is open, press Alt+S to focus the filter field. As you type, the list of work orders updates to show only the matching entries. Clearing the filter restores the full list.