Repository navigation
Conversation
* Update launch.lua - Arena * Update ghostly.lua - Arena * Update resurrect-adv.lua - Arena * Update position.lua - Arena * Update resize-armor.lua - Arena * Update toggle-kbd-cursor.lua - Arena * Update markdown.lua - Arena * Update advtools.lua - Arena * Update gui/notify.lua - Arena * Update skills-progress.lua - Arena * Update gui/reveal.lua - Disallow arena * Update changelog.txt
* Update position.lua - Revert, no meaningful arena position * Update changelog.txt - Revert position * Update advtools.lua * Update ghostly.lua * Update notify.lua * Update skills-progress.lua * Update launch.lua * Update markdown.lua * Update resize-armor.lua * Update resurrect-adv.lua * Update toggle-kbd-cursor.lua
Bumber64
marked this pull request as ready for review
October 5, 2026 18:32
SilasD
reviewed
Oct 6, 2026
SilasD
left a comment
SilasD
left a comment
Contributor
There was a problem hiding this comment.
this generally seems solid.
I don't really like moving away from clean getters to probing fields directly,
df.global.gamemode == df.game_mode.ADVENTURE feels clunkier.
is there no combo like isAdventureMode() and not isArena() that can do the job?
| if not dfhack.isMapLoaded() then | ||
| qerror('This script requires a map to be loaded') | ||
| elseif dfhack.world.isArena() then | ||
| qerror('This script doesn\'t work in arena mode') |
Contributor
There was a problem hiding this comment.
no real need to escape this apostrophe.
Suggested change
| qerror('This script doesn\'t work in arena mode') | |
| qerror("This script doesn't work in arena mode") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after DFHack/dfhack#5991.
Enable more scripts to work properly in adventure arena. Disable
gui/revealin arena sincerevealreturnsCR_FAILURE.gui/create-itemfix is implicit fromgetAdventurerfix.