Format judgedaemon code according to PSR-2. #3288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
approved these changes
Dec 7, 2025
Member
vmcj
left a comment
vmcj
left a comment
There was a problem hiding this comment.
I like consistency, not sure if it really improves the readability here but it also does not make it worse.
Kevinjil
approved these changes
Dec 8, 2025
eldering
reviewed
Dec 10, 2025
| if ($retval !== DONT_CARE) $retval = $retval_local; // phpcs:ignore Generic.ControlStructures.InlineControlStructure.NotAllowed | ||
| if ($retval !== DONT_CARE) { | ||
| $retval = $retval_local; | ||
| } // phpcs:ignore Generic.ControlStructures.InlineControlStructure.NotAllowed |
Member
There was a problem hiding this comment.
This was explicitly marked to not get reformatted, so I wonder what happened here.
I'd prefer the old way, but at least the comment should not be left like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.