[TSPS-704] Uses outputExpirationDate for Deletion Date in Job History page
#5451
Conversation
mmorgantaylor
left a comment
mmorgantaylor
left a comment
There was a problem hiding this comment.
looking great, one question
| expect(viewOutputsButton).toBeDisabled(); | ||
|
|
||
| const user = userEvent.setup(); | ||
| await user.hover(viewOutputsButton); |
There was a problem hiding this comment.
so cool to test the hover text!
| }); | ||
|
|
||
| const jobOutputsDeleted = | ||
| const jobOutputsDeleted = !!( |
There was a problem hiding this comment.
I'm having trouble understanding why the addition of !! here didn't change the pipelineRun.status === 'SUCCEEDED' logic. doesn't this mean that jobOutputsDeleted will be True for failed/running jobs? does it not matter because jobOutputsDeleted is only used further down if pipelineRun.status === 'SUCCEEDED' (line 348)? this is still confusing to me to read, but I might be misunderstanding this logic
There was a problem hiding this comment.
The !! here converts that expression into a strict boolean value other wise the data type of jobOutputsDeleted will be boolean | " " | undefined. I can add that as a comment as it can be definitely confusing?
There was a problem hiding this comment.
oh goodness, sorry, that's just me not understanding what !! means. thanks for the explanation - I don't think you need a comment here.
There was a problem hiding this comment.
No worries. I did add it as a comment because javascript is confusing and I too as code author did get confused initially.
MatthewBemis
left a comment
MatthewBemis
left a comment
There was a problem hiding this comment.
This looks awesome, and thank you for backfilling the test coverage that checks for the red deletion dates!
|
Jira Ticket: https://broadworkbench.atlassian.net/browse/TSPS-704
Summary of changes:
What
outputExpirationDatereturned from listPipelineRuns response to display Deletion Date in Job History pageWhy
Testing strategy