Skip to content

Enable Bazel runfiles on Windows with widened test surface #48206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 1 commit into from
Mar 24, 2026
Merged

Enable Bazel runfiles on Windows with widened test surface #48206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ common:macos --remote_local_fallback_strategy=sandboxed

# Windows config -------------------------------------------------------------------------------------------------------
common:windows --strategy=standalone # Valid values are: [dynamic_worker, standalone, dynamic, remote, worker, local]
# rules_python 1.9.0 transitions enable_runfiles to `true` for every py_ target on Windows. Pre-setting it here makes
# that transition a no-op, so Bazel deduplicates python_win and avoids 2 concurrent MSBuild racing on shared resources.
common:windows --enable_runfiles
# Neither repo_env nor shell_executable affect action keys. It can be both an advantage and a disadvantage.
# For instance, if we need to have some special behavior in bash we can add it, however, in some cases
# it may lead to cache poisoning.
Expand Down
18 changes: 16 additions & 2 deletions .gitlab/build/bazel/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,19 @@ bazel:test:macos-arm64:
bazel:test:windows-amd64:
extends: [ .bazel:test, .bazel:runner:windows-amd64 ]
variables:
POWERSHELL_SCRIPT: |-
bazel test //bazel/tests/... //rtloader/...
POWERSHELL_SCRIPT: >-
bazel test //... --
-//bazel/rules/dd_packaging/...
-//internal/tools/modparser:modparser_test
-//internal/tools/worksynchronizer:worksynchronizer_test
-//packages/agent/linux/...
-//pkg/collector/corechecks/ebpf/probe/...
-//pkg/dyninst/loader/...
-//pkg/dyninst/output/...
-//pkg/ebpf/...
-//pkg/gpu/ebpf/...
-//pkg/network/...
-//pkg/networkdevice/profile/profiledefinition/schema:schema_test
-//pkg/template/...

# //pkg/template:generate_N_test: TODO(regis) .gopatch files seem to be altered by .gitattributes
2 changes: 1 addition & 1 deletion MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ register_toolchains(
visual_studio(
name = "visual_studio",
path_variable = "VSTUDIO_ROOT",
version = "17.14.36717.8",
version = "17.14.36717.8", # 18.4.11612.150
)

# =========================================
Expand Down
Loading