-
Notifications
You must be signed in to change notification settings - Fork 319
Remove instrumentation afterEvaluate
#9752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bric3
wants to merge
2
commits into
master
Choose a base branch
from
bdu/avoid-afterEvaluate-in-instrumentation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d930307 to
ff71451
Compare
This comment has been minimized.
This comment has been minimized.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~bd9e60cdc1, baseline=1.56.0-SNAPSHOT~0614d7316c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.103 s) : 0, 1103197
Total [baseline] (8.895 s) : 0, 8895321
Agent [candidate] (1.11 s) : 0, 1109768
Total [candidate] (8.914 s) : 0, 8914283
section iast
Agent [baseline] (1.25 s) : 0, 1249732
Total [baseline] (9.588 s) : 0, 9587895
Agent [candidate] (1.255 s) : 0, 1254564
Total [candidate] (9.588 s) : 0, 9588214
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~bd9e60cdc1, baseline=1.56.0-SNAPSHOT~0614d7316c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.484 ms) : 0, 1484
BytebuddyAgent [baseline] (709.35 ms) : 0, 709350
BytebuddyAgent [candidate] (713.385 ms) : 0, 713385
GlobalTracer [baseline] (249.478 ms) : 0, 249478
GlobalTracer [candidate] (251.019 ms) : 0, 251019
AppSec [baseline] (32.093 ms) : 0, 32093
AppSec [candidate] (32.352 ms) : 0, 32352
Debugger [baseline] (63.276 ms) : 0, 63276
Debugger [candidate] (63.65 ms) : 0, 63650
Remote Config [baseline] (624.801 µs) : 0, 625
Remote Config [candidate] (634.567 µs) : 0, 635
Telemetry [baseline] (8.231 ms) : 0, 8231
Telemetry [candidate] (8.345 ms) : 0, 8345
Flare Poller [baseline] (3.693 ms) : 0, 3693
Flare Poller [candidate] (3.745 ms) : 0, 3745
section iast
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.484 ms) : 0, 1484
BytebuddyAgent [baseline] (841.108 ms) : 0, 841108
BytebuddyAgent [candidate] (842.99 ms) : 0, 842990
GlobalTracer [baseline] (238.966 ms) : 0, 238966
GlobalTracer [candidate] (239.664 ms) : 0, 239664
AppSec [baseline] (32.302 ms) : 0, 32302
AppSec [candidate] (34.206 ms) : 0, 34206
Debugger [baseline] (59.775 ms) : 0, 59775
Debugger [candidate] (61.02 ms) : 0, 61020
Remote Config [baseline] (560.176 µs) : 0, 560
Remote Config [candidate] (546.397 µs) : 0, 546
Telemetry [baseline] (7.59 ms) : 0, 7590
Telemetry [candidate] (7.632 ms) : 0, 7632
Flare Poller [baseline] (3.451 ms) : 0, 3451
Flare Poller [candidate] (3.519 ms) : 0, 3519
IAST [baseline] (29.265 ms) : 0, 29265
IAST [candidate] (27.91 ms) : 0, 27910
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~bd9e60cdc1, baseline=1.56.0-SNAPSHOT~0614d7316c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.108 s) : 0, 1107510
Total [baseline] (7.494 s) : 0, 7493580
Agent [candidate] (1.109 s) : 0, 1109280
Total [candidate] (10.851 s) : 0, 10851330
section appsec
Agent [baseline] (1.315 s) : 0, 1314631
Total [baseline] (11.339 s) : 0, 11338777
Agent [candidate] (1.302 s) : 0, 1301784
Total [candidate] (11.285 s) : 0, 11285072
section iast
Agent [baseline] (1.249 s) : 0, 1248750
Total [baseline] (11.377 s) : 0, 11377079
Agent [candidate] (1.267 s) : 0, 1266747
Total [candidate] (11.429 s) : 0, 11429456
section profiling
Agent [baseline] (1.241 s) : 0, 1241133
Total [baseline] (11.226 s) : 0, 11225667
Agent [candidate] (1.243 s) : 0, 1242988
Total [candidate] (11.191 s) : 0, 11191411
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~bd9e60cdc1, baseline=1.56.0-SNAPSHOT~0614d7316c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (711.562 ms) : 0, 711562
BytebuddyAgent [candidate] (712.011 ms) : 0, 712011
GlobalTracer [baseline] (250.699 ms) : 0, 250699
GlobalTracer [candidate] (251.222 ms) : 0, 251222
AppSec [baseline] (32.375 ms) : 0, 32375
AppSec [candidate] (32.283 ms) : 0, 32283
Debugger [baseline] (63.909 ms) : 0, 63909
Debugger [candidate] (64.201 ms) : 0, 64201
Remote Config [baseline] (618.928 µs) : 0, 619
Remote Config [candidate] (632.586 µs) : 0, 633
Telemetry [baseline] (8.239 ms) : 0, 8239
Telemetry [candidate] (8.442 ms) : 0, 8442
Flare Poller [baseline] (3.732 ms) : 0, 3732
Flare Poller [candidate] (3.821 ms) : 0, 3821
section appsec
crashtracking [baseline] (1.518 ms) : 0, 1518
crashtracking [candidate] (1.481 ms) : 0, 1481
BytebuddyAgent [baseline] (752.965 ms) : 0, 752965
BytebuddyAgent [candidate] (744.847 ms) : 0, 744847
GlobalTracer [baseline] (247.598 ms) : 0, 247598
GlobalTracer [candidate] (244.906 ms) : 0, 244906
AppSec [baseline] (176.027 ms) : 0, 176027
AppSec [candidate] (174.78 ms) : 0, 174780
Debugger [baseline] (62.282 ms) : 0, 62282
Debugger [candidate] (62.42 ms) : 0, 62420
Remote Config [baseline] (666.105 µs) : 0, 666
Remote Config [candidate] (663.31 µs) : 0, 663
Telemetry [baseline] (8.204 ms) : 0, 8204
Telemetry [candidate] (8.165 ms) : 0, 8165
Flare Poller [baseline] (3.914 ms) : 0, 3914
Flare Poller [candidate] (3.948 ms) : 0, 3948
IAST [baseline] (25.539 ms) : 0, 25539
IAST [candidate] (25.017 ms) : 0, 25017
section iast
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.493 ms) : 0, 1493
BytebuddyAgent [baseline] (837.758 ms) : 0, 837758
BytebuddyAgent [candidate] (851.513 ms) : 0, 851513
GlobalTracer [baseline] (239.369 ms) : 0, 239369
GlobalTracer [candidate] (240.796 ms) : 0, 240796
AppSec [baseline] (32.389 ms) : 0, 32389
AppSec [candidate] (33.663 ms) : 0, 33663
Debugger [baseline] (61.391 ms) : 0, 61391
Debugger [candidate] (62.544 ms) : 0, 62544
Remote Config [baseline] (559.098 µs) : 0, 559
Remote Config [candidate] (564.767 µs) : 0, 565
Telemetry [baseline] (7.631 ms) : 0, 7631
Telemetry [candidate] (7.898 ms) : 0, 7898
Flare Poller [baseline] (3.5 ms) : 0, 3500
Flare Poller [candidate] (3.662 ms) : 0, 3662
IAST [baseline] (29.429 ms) : 0, 29429
IAST [candidate] (29.03 ms) : 0, 29030
section profiling
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (739.272 ms) : 0, 739272
BytebuddyAgent [candidate] (740.725 ms) : 0, 740725
GlobalTracer [baseline] (224.3 ms) : 0, 224300
GlobalTracer [candidate] (224.122 ms) : 0, 224122
AppSec [baseline] (32.27 ms) : 0, 32270
AppSec [candidate] (32.412 ms) : 0, 32412
Debugger [baseline] (63.303 ms) : 0, 63303
Debugger [candidate] (63.593 ms) : 0, 63593
Remote Config [baseline] (665.539 µs) : 0, 666
Remote Config [candidate] (652.649 µs) : 0, 653
Telemetry [baseline] (8.132 ms) : 0, 8132
Telemetry [candidate] (8.056 ms) : 0, 8056
Flare Poller [baseline] (3.808 ms) : 0, 3808
Flare Poller [candidate] (3.739 ms) : 0, 3739
ProfilingAgent [baseline] (97.728 ms) : 0, 97728
ProfilingAgent [candidate] (97.96 ms) : 0, 97960
Profiling [baseline] (98.32 ms) : 0, 98320
Profiling [candidate] (98.553 ms) : 0, 98553
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~bd9e60cdc1, baseline=1.56.0-SNAPSHOT~0614d7316c
dateFormat X
axisFormat %s
section baseline
no_agent (1.205 ms) : 1193, 1216
. : milestone, 1205,
iast (3.222 ms) : 3182, 3262
. : milestone, 3222,
iast_FULL (5.774 ms) : 5717, 5832
. : milestone, 5774,
iast_GLOBAL (3.639 ms) : 3590, 3688
. : milestone, 3639,
profiling (2.09 ms) : 2072, 2107
. : milestone, 2090,
tracing (1.812 ms) : 1797, 1828
. : milestone, 1812,
section candidate
no_agent (1.207 ms) : 1195, 1219
. : milestone, 1207,
iast (3.194 ms) : 3153, 3235
. : milestone, 3194,
iast_FULL (5.934 ms) : 5873, 5994
. : milestone, 5934,
iast_GLOBAL (3.608 ms) : 3554, 3663
. : milestone, 3608,
profiling (2.217 ms) : 2194, 2240
. : milestone, 2217,
tracing (1.83 ms) : 1815, 1845
. : milestone, 1830,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~bd9e60cdc1, baseline=1.56.0-SNAPSHOT~0614d7316c
dateFormat X
axisFormat %s
section baseline
no_agent (19.263 ms) : 19064, 19462
. : milestone, 19263,
appsec (18.84 ms) : 18648, 19032
. : milestone, 18840,
code_origins (17.947 ms) : 17766, 18127
. : milestone, 17947,
iast (17.601 ms) : 17424, 17777
. : milestone, 17601,
profiling (19.911 ms) : 19709, 20113
. : milestone, 19911,
tracing (17.657 ms) : 17483, 17831
. : milestone, 17657,
section candidate
no_agent (17.869 ms) : 17690, 18048
. : milestone, 17869,
appsec (18.398 ms) : 18211, 18586
. : milestone, 18398,
code_origins (18.82 ms) : 18633, 19008
. : milestone, 18820,
iast (17.7 ms) : 17522, 17877
. : milestone, 17700,
profiling (18.368 ms) : 18186, 18550
. : milestone, 18368,
tracing (17.244 ms) : 17074, 17414
. : milestone, 17244,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~bd9e60cdc1, baseline=1.56.0-SNAPSHOT~0614d7316c
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.695 ms) : 3477, 3913
. : milestone, 3695,
iast (2.209 ms) : 2144, 2273
. : milestone, 2209,
iast_GLOBAL (2.25 ms) : 2186, 2315
. : milestone, 2250,
profiling (2.067 ms) : 2014, 2119
. : milestone, 2067,
tracing (2.047 ms) : 1996, 2099
. : milestone, 2047,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.639 ms) : 3424, 3854
. : milestone, 3639,
iast (2.213 ms) : 2148, 2277
. : milestone, 2213,
iast_GLOBAL (2.251 ms) : 2186, 2316
. : milestone, 2251,
profiling (2.07 ms) : 2018, 2123
. : milestone, 2070,
tracing (2.041 ms) : 1990, 2092
. : milestone, 2041,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~bd9e60cdc1, baseline=1.56.0-SNAPSHOT~0614d7316c
dateFormat X
axisFormat %s
section baseline
no_agent (15.028 s) : 15028000, 15028000
. : milestone, 15028000,
appsec (14.62 s) : 14620000, 14620000
. : milestone, 14620000,
iast (18.491 s) : 18491000, 18491000
. : milestone, 18491000,
iast_GLOBAL (18.324 s) : 18324000, 18324000
. : milestone, 18324000,
profiling (14.784 s) : 14784000, 14784000
. : milestone, 14784000,
tracing (14.671 s) : 14671000, 14671000
. : milestone, 14671000,
section candidate
no_agent (15.256 s) : 15256000, 15256000
. : milestone, 15256000,
appsec (14.753 s) : 14753000, 14753000
. : milestone, 14753000,
iast (18.437 s) : 18437000, 18437000
. : milestone, 18437000,
iast_GLOBAL (18.203 s) : 18203000, 18203000
. : milestone, 18203000,
profiling (14.695 s) : 14695000, 14695000
. : milestone, 14695000,
tracing (14.965 s) : 14965000, 14965000
. : milestone, 14965000,
|
5388f6d to
4835e7b
Compare
# Conflicts: # dd-java-agent/instrumentation/build.gradle
4835e7b to
bd9e60c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: tooling
Build & Tooling
tag: no release notes
Changes to exclude from release notes
type: enhancement
Enhancements and improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Removes instrumentation module's
afterEvaluate.This looks like it is reducing sync time to ~1min on my M1

Motivation
Using
afterEvaluateis a bad practice and has tighter restriction in Gradle 9+.https://docs.gradle.org/9.1.0/userguide/task_configuration_avoidance.html#8_some_apis_may_be_disallowed_if_you_try_to_access_them_from_the_new_apis_configuration_blocks
It introduces subtle ordering issues which can be very challenging to debug.
From my notes:
Additional Notes
Blocked by
testJvmConstraintsGradle extension to replace extra properties #9892Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]