-
Notifications
You must be signed in to change notification settings - Fork 319
add inject datadog attribute config #9943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~1101fc8949, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1088614
Total [baseline] (9.347 s) : 0, 9347427
Agent [candidate] (1.086 s) : 0, 1085923
Total [candidate] (9.393 s) : 0, 9393498
section iast
Agent [baseline] (1.229 s) : 0, 1229285
Total [baseline] (10.133 s) : 0, 10132844
Agent [candidate] (1.23 s) : 0, 1229687
Total [candidate] (10.031 s) : 0, 10031279
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~1101fc8949, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.564 ms) : 0, 1564
crashtracking [candidate] (1.542 ms) : 0, 1542
BytebuddyAgent [baseline] (729.684 ms) : 0, 729684
BytebuddyAgent [candidate] (726.438 ms) : 0, 726438
GlobalTracer [baseline] (260.033 ms) : 0, 260033
GlobalTracer [candidate] (260.316 ms) : 0, 260316
AppSec [baseline] (33.213 ms) : 0, 33213
AppSec [candidate] (33.273 ms) : 0, 33273
Debugger [baseline] (6.701 ms) : 0, 6701
Debugger [candidate] (6.731 ms) : 0, 6731
Remote Config [baseline] (701.888 µs) : 0, 702
Remote Config [candidate] (704.297 µs) : 0, 704
Telemetry [baseline] (15.328 ms) : 0, 15328
Telemetry [candidate] (16.457 ms) : 0, 16457
Flare Poller [baseline] (5.889 ms) : 0, 5889
Flare Poller [candidate] (4.995 ms) : 0, 4995
section iast
crashtracking [baseline] (1.575 ms) : 0, 1575
crashtracking [candidate] (1.543 ms) : 0, 1543
BytebuddyAgent [baseline] (853.342 ms) : 0, 853342
BytebuddyAgent [candidate] (853.305 ms) : 0, 853305
GlobalTracer [baseline] (248.24 ms) : 0, 248240
GlobalTracer [candidate] (248.006 ms) : 0, 248006
IAST [baseline] (31.611 ms) : 0, 31611
IAST [candidate] (30.53 ms) : 0, 30530
AppSec [baseline] (32.235 ms) : 0, 32235
AppSec [candidate] (33.999 ms) : 0, 33999
Debugger [baseline] (6.306 ms) : 0, 6306
Debugger [candidate] (6.32 ms) : 0, 6320
Remote Config [baseline] (647.845 µs) : 0, 648
Remote Config [candidate] (646.615 µs) : 0, 647
Telemetry [baseline] (8.686 ms) : 0, 8686
Telemetry [candidate] (8.621 ms) : 0, 8621
Flare Poller [baseline] (11.079 ms) : 0, 11079
Flare Poller [candidate] (11.242 ms) : 0, 11242
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~1101fc8949, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084097
Total [baseline] (11.11 s) : 0, 11109579
Agent [candidate] (1.084 s) : 0, 1084384
Total [candidate] (11.093 s) : 0, 11093160
section appsec
Agent [baseline] (1.262 s) : 0, 1262175
Total [baseline] (11.277 s) : 0, 11277151
Agent [candidate] (1.265 s) : 0, 1264787
Total [candidate] (11.352 s) : 0, 11352176
section iast
Agent [baseline] (1.225 s) : 0, 1225044
Total [baseline] (11.547 s) : 0, 11546517
Agent [candidate] (1.226 s) : 0, 1226260
Total [candidate] (11.479 s) : 0, 11479474
section profiling
Agent [baseline] (1.23 s) : 0, 1229521
Total [baseline] (11.315 s) : 0, 11314963
Agent [candidate] (1.231 s) : 0, 1231150
Total [candidate] (11.485 s) : 0, 11484510
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~1101fc8949, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.547 ms) : 0, 1547
crashtracking [candidate] (1.542 ms) : 0, 1542
BytebuddyAgent [baseline] (725.147 ms) : 0, 725147
BytebuddyAgent [candidate] (725.722 ms) : 0, 725722
GlobalTracer [baseline] (259.913 ms) : 0, 259913
GlobalTracer [candidate] (260.112 ms) : 0, 260112
AppSec [baseline] (33.15 ms) : 0, 33150
AppSec [candidate] (32.891 ms) : 0, 32891
Debugger [baseline] (6.661 ms) : 0, 6661
Debugger [candidate] (6.671 ms) : 0, 6671
Remote Config [baseline] (707.647 µs) : 0, 708
Remote Config [candidate] (703.385 µs) : 0, 703
Telemetry [baseline] (15.642 ms) : 0, 15642
Telemetry [candidate] (16.409 ms) : 0, 16409
Flare Poller [baseline] (5.971 ms) : 0, 5971
Flare Poller [candidate] (4.973 ms) : 0, 4973
section appsec
crashtracking [baseline] (1.543 ms) : 0, 1543
crashtracking [candidate] (1.544 ms) : 0, 1544
BytebuddyAgent [baseline] (748.852 ms) : 0, 748852
BytebuddyAgent [candidate] (750.514 ms) : 0, 750514
GlobalTracer [baseline] (250.534 ms) : 0, 250534
GlobalTracer [candidate] (250.758 ms) : 0, 250758
IAST [baseline] (25.915 ms) : 0, 25915
IAST [candidate] (26.107 ms) : 0, 26107
AppSec [baseline] (180.034 ms) : 0, 180034
AppSec [candidate] (180.612 ms) : 0, 180612
Debugger [baseline] (6.554 ms) : 0, 6554
Debugger [candidate] (6.514 ms) : 0, 6514
Remote Config [baseline] (721.076 µs) : 0, 721
Remote Config [candidate] (753.623 µs) : 0, 754
Telemetry [baseline] (8.472 ms) : 0, 8472
Telemetry [candidate] (8.472 ms) : 0, 8472
Flare Poller [baseline] (4.113 ms) : 0, 4113
Flare Poller [candidate] (4.021 ms) : 0, 4021
section iast
crashtracking [baseline] (1.541 ms) : 0, 1541
crashtracking [candidate] (1.545 ms) : 0, 1545
BytebuddyAgent [baseline] (850.291 ms) : 0, 850291
BytebuddyAgent [candidate] (851.589 ms) : 0, 851589
GlobalTracer [baseline] (246.98 ms) : 0, 246980
GlobalTracer [candidate] (247.583 ms) : 0, 247583
IAST [baseline] (28.702 ms) : 0, 28702
IAST [candidate] (33.438 ms) : 0, 33438
AppSec [baseline] (35.243 ms) : 0, 35243
AppSec [candidate] (30.35 ms) : 0, 30350
Debugger [baseline] (6.374 ms) : 0, 6374
Debugger [candidate] (6.339 ms) : 0, 6339
Remote Config [baseline] (657.445 µs) : 0, 657
Remote Config [candidate] (639.478 µs) : 0, 639
Telemetry [baseline] (8.712 ms) : 0, 8712
Telemetry [candidate] (8.342 ms) : 0, 8342
Flare Poller [baseline] (11.029 ms) : 0, 11029
Flare Poller [candidate] (10.958 ms) : 0, 10958
section profiling
crashtracking [baseline] (1.507 ms) : 0, 1507
crashtracking [candidate] (1.516 ms) : 0, 1516
BytebuddyAgent [baseline] (751.57 ms) : 0, 751570
BytebuddyAgent [candidate] (752.602 ms) : 0, 752602
GlobalTracer [baseline] (230.718 ms) : 0, 230718
GlobalTracer [candidate] (231.372 ms) : 0, 231372
AppSec [baseline] (33.206 ms) : 0, 33206
AppSec [candidate] (33.13 ms) : 0, 33130
Debugger [baseline] (9.646 ms) : 0, 9646
Debugger [candidate] (8.817 ms) : 0, 8817
Remote Config [baseline] (716.84 µs) : 0, 717
Remote Config [candidate] (707.398 µs) : 0, 707
Telemetry [baseline] (14.663 ms) : 0, 14663
Telemetry [candidate] (15.331 ms) : 0, 15331
Flare Poller [baseline] (4.365 ms) : 0, 4365
Flare Poller [candidate] (4.344 ms) : 0, 4344
ProfilingAgent [baseline] (112.963 ms) : 0, 112963
ProfilingAgent [candidate] (112.923 ms) : 0, 112923
Profiling [baseline] (113.631 ms) : 0, 113631
Profiling [candidate] (113.613 ms) : 0, 113613
LoadParameters
See matching parameters
SummaryFound 5 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~1101fc8949, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section baseline
no_agent (1.273 ms) : 1261, 1285
. : milestone, 1273,
iast (3.332 ms) : 3283, 3380
. : milestone, 3332,
iast_FULL (5.827 ms) : 5769, 5885
. : milestone, 5827,
iast_GLOBAL (3.622 ms) : 3560, 3684
. : milestone, 3622,
profiling (2.164 ms) : 2141, 2186
. : milestone, 2164,
tracing (1.811 ms) : 1796, 1826
. : milestone, 1811,
section candidate
no_agent (1.215 ms) : 1203, 1227
. : milestone, 1215,
iast (3.105 ms) : 3068, 3143
. : milestone, 3105,
iast_FULL (5.574 ms) : 5518, 5629
. : milestone, 5574,
iast_GLOBAL (3.675 ms) : 3614, 3737
. : milestone, 3675,
profiling (2.029 ms) : 2011, 2048
. : milestone, 2029,
tracing (1.817 ms) : 1800, 1834
. : milestone, 1817,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~1101fc8949, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section baseline
no_agent (18.944 ms) : 18750, 19138
. : milestone, 18944,
appsec (18.297 ms) : 18108, 18486
. : milestone, 18297,
code_origins (17.711 ms) : 17534, 17887
. : milestone, 17711,
iast (17.533 ms) : 17357, 17709
. : milestone, 17533,
profiling (20.398 ms) : 20194, 20601
. : milestone, 20398,
tracing (19.81 ms) : 19610, 20009
. : milestone, 19810,
section candidate
no_agent (18.374 ms) : 18185, 18564
. : milestone, 18374,
appsec (18.52 ms) : 18331, 18710
. : milestone, 18520,
code_origins (17.748 ms) : 17573, 17924
. : milestone, 17748,
iast (17.476 ms) : 17300, 17652
. : milestone, 17476,
profiling (19.53 ms) : 19331, 19728
. : milestone, 19530,
tracing (17.798 ms) : 17619, 17978
. : milestone, 17798,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~1101fc8949, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1489
. : milestone, 1477,
appsec (3.709 ms) : 3491, 3927
. : milestone, 3709,
iast (2.21 ms) : 2146, 2274
. : milestone, 2210,
iast_GLOBAL (2.256 ms) : 2191, 2321
. : milestone, 2256,
profiling (2.099 ms) : 2046, 2153
. : milestone, 2099,
tracing (2.047 ms) : 1996, 2097
. : milestone, 2047,
section candidate
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (2.536 ms) : 2480, 2592
. : milestone, 2536,
iast (2.215 ms) : 2150, 2279
. : milestone, 2215,
iast_GLOBAL (2.262 ms) : 2197, 2326
. : milestone, 2262,
profiling (2.093 ms) : 2039, 2147
. : milestone, 2093,
tracing (2.05 ms) : 1999, 2100
. : milestone, 2050,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~1101fc8949, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section baseline
no_agent (15.474 s) : 15474000, 15474000
. : milestone, 15474000,
appsec (14.972 s) : 14972000, 14972000
. : milestone, 14972000,
iast (18.772 s) : 18772000, 18772000
. : milestone, 18772000,
iast_GLOBAL (17.858 s) : 17858000, 17858000
. : milestone, 17858000,
profiling (14.462 s) : 14462000, 14462000
. : milestone, 14462000,
tracing (14.916 s) : 14916000, 14916000
. : milestone, 14916000,
section candidate
no_agent (14.914 s) : 14914000, 14914000
. : milestone, 14914000,
appsec (15.109 s) : 15109000, 15109000
. : milestone, 15109000,
iast (18.288 s) : 18288000, 18288000
. : milestone, 18288000,
iast_GLOBAL (17.771 s) : 17771000, 17771000
. : milestone, 17771000,
profiling (14.718 s) : 14718000, 14718000
. : milestone, 14718000,
tracing (14.966 s) : 14966000, 14966000
. : milestone, 14966000,
|
mhlidd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments/nits!
What Does This Do
Motivation
FRSLES-777
APMSVLS-274
tldr: currently, injecting _datadog attribute into Step Function input is disrupting Glue-based automation pipeline, due to schema constraints.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMSVLS-247