-
Notifications
You must be signed in to change notification settings - Fork 317
Use ClassNameTrie from its new location in dd-instrument-java
#9977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
aa6b425 to
090d6c1
Compare
This comment has been minimized.
This comment has been minimized.
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 7 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (333.549 µs) : 279, 388
. : milestone, 334,
basic (295.014 µs) : 288, 302
. : milestone, 295,
loop (8.448 ms) : 8386, 8511
. : milestone, 8448,
section candidate
noprobe (324.319 µs) : 298, 350
. : milestone, 324,
basic (294.872 µs) : 287, 302
. : milestone, 295,
loop (8.441 ms) : 8379, 8502
. : milestone, 8441,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~e18ea8f5f7, baseline=1.56.0-SNAPSHOT~fb40abaeee
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.097 s) : 0, 1097305
Total [baseline] (8.844 s) : 0, 8844099
Agent [candidate] (1.1 s) : 0, 1100051
Total [candidate] (8.85 s) : 0, 8850248
section iast
Agent [baseline] (1.236 s) : 0, 1235937
Total [baseline] (9.527 s) : 0, 9526532
Agent [candidate] (1.238 s) : 0, 1237619
Total [candidate] (9.54 s) : 0, 9539677
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~e18ea8f5f7, baseline=1.56.0-SNAPSHOT~fb40abaeee
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.446 ms) : 0, 1446
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (704.697 ms) : 0, 704697
BytebuddyAgent [candidate] (706.871 ms) : 0, 706871
GlobalTracer [baseline] (248.179 ms) : 0, 248179
GlobalTracer [candidate] (248.86 ms) : 0, 248860
AppSec [baseline] (32.153 ms) : 0, 32153
AppSec [candidate] (32.329 ms) : 0, 32329
Debugger [baseline] (63.509 ms) : 0, 63509
Debugger [candidate] (63.18 ms) : 0, 63180
Remote Config [baseline] (630.246 µs) : 0, 630
Remote Config [candidate] (634.117 µs) : 0, 634
Telemetry [baseline] (8.202 ms) : 0, 8202
Telemetry [candidate] (8.252 ms) : 0, 8252
Flare Poller [baseline] (3.682 ms) : 0, 3682
Flare Poller [candidate] (3.693 ms) : 0, 3693
section iast
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (828.611 ms) : 0, 828611
BytebuddyAgent [candidate] (828.023 ms) : 0, 828023
GlobalTracer [baseline] (237.641 ms) : 0, 237641
GlobalTracer [candidate] (239.194 ms) : 0, 239194
AppSec [baseline] (32.632 ms) : 0, 32632
AppSec [candidate] (34.25 ms) : 0, 34250
Debugger [baseline] (59.993 ms) : 0, 59993
Debugger [candidate] (60.38 ms) : 0, 60380
Remote Config [baseline] (548.722 µs) : 0, 549
Remote Config [candidate] (557.474 µs) : 0, 557
Telemetry [baseline] (7.623 ms) : 0, 7623
Telemetry [candidate] (7.652 ms) : 0, 7652
Flare Poller [baseline] (3.449 ms) : 0, 3449
Flare Poller [candidate] (3.453 ms) : 0, 3453
IAST [baseline] (29.216 ms) : 0, 29216
IAST [candidate] (27.794 ms) : 0, 27794
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~e18ea8f5f7, baseline=1.56.0-SNAPSHOT~fb40abaeee
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.107 s) : 0, 1106775
Total [baseline] (10.763 s) : 0, 10763217
Agent [candidate] (1.099 s) : 0, 1099031
Total [candidate] (10.778 s) : 0, 10777746
section appsec
Agent [baseline] (1.277 s) : 0, 1277393
Total [baseline] (10.957 s) : 0, 10957304
Agent [candidate] (1.278 s) : 0, 1278316
Total [candidate] (11.017 s) : 0, 11017426
section iast
Agent [baseline] (1.245 s) : 0, 1244658
Total [baseline] (11.245 s) : 0, 11245489
Agent [candidate] (1.237 s) : 0, 1237445
Total [candidate] (11.297 s) : 0, 11297071
section profiling
Agent [baseline] (1.231 s) : 0, 1231289
Total [baseline] (11.064 s) : 0, 11064340
Agent [candidate] (1.229 s) : 0, 1229167
Total [candidate] (11.032 s) : 0, 11032364
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~e18ea8f5f7, baseline=1.56.0-SNAPSHOT~fb40abaeee
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.485 ms) : 0, 1485
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (710.265 ms) : 0, 710265
BytebuddyAgent [candidate] (705.043 ms) : 0, 705043
GlobalTracer [baseline] (250.208 ms) : 0, 250208
GlobalTracer [candidate] (248.731 ms) : 0, 248731
AppSec [baseline] (32.563 ms) : 0, 32563
AppSec [candidate] (32.201 ms) : 0, 32201
Debugger [baseline] (64.775 ms) : 0, 64775
Debugger [candidate] (64.312 ms) : 0, 64312
Remote Config [baseline] (644.824 µs) : 0, 645
Remote Config [candidate] (637.842 µs) : 0, 638
Telemetry [baseline] (8.237 ms) : 0, 8237
Telemetry [candidate] (8.255 ms) : 0, 8255
Flare Poller [baseline] (3.688 ms) : 0, 3688
Flare Poller [candidate] (3.692 ms) : 0, 3692
section appsec
crashtracking [baseline] (1.447 ms) : 0, 1447
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (728.441 ms) : 0, 728441
BytebuddyAgent [candidate] (728.856 ms) : 0, 728856
GlobalTracer [baseline] (239.792 ms) : 0, 239792
GlobalTracer [candidate] (240.631 ms) : 0, 240631
IAST [baseline] (24.894 ms) : 0, 24894
IAST [candidate] (24.727 ms) : 0, 24727
AppSec [baseline] (174.625 ms) : 0, 174625
AppSec [candidate] (174.214 ms) : 0, 174214
Debugger [baseline] (60.522 ms) : 0, 60522
Debugger [candidate] (60.578 ms) : 0, 60578
Remote Config [baseline] (673.496 µs) : 0, 673
Remote Config [candidate] (701.218 µs) : 0, 701
Telemetry [baseline] (8.294 ms) : 0, 8294
Telemetry [candidate] (8.327 ms) : 0, 8327
Flare Poller [baseline] (3.839 ms) : 0, 3839
Flare Poller [candidate] (3.88 ms) : 0, 3880
section iast
crashtracking [baseline] (1.446 ms) : 0, 1446
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (833.609 ms) : 0, 833609
BytebuddyAgent [candidate] (828.383 ms) : 0, 828383
GlobalTracer [baseline] (239.684 ms) : 0, 239684
GlobalTracer [candidate] (238.483 ms) : 0, 238483
IAST [baseline] (27.765 ms) : 0, 27765
IAST [candidate] (28.909 ms) : 0, 28909
AppSec [baseline] (34.202 ms) : 0, 34202
AppSec [candidate] (32.371 ms) : 0, 32371
Debugger [baseline] (61.377 ms) : 0, 61377
Debugger [candidate] (61.203 ms) : 0, 61203
Remote Config [baseline] (548.828 µs) : 0, 549
Remote Config [candidate] (545.653 µs) : 0, 546
Telemetry [baseline] (7.699 ms) : 0, 7699
Telemetry [candidate] (7.746 ms) : 0, 7746
Flare Poller [baseline] (3.462 ms) : 0, 3462
Flare Poller [candidate] (3.546 ms) : 0, 3546
section profiling
crashtracking [baseline] (1.439 ms) : 0, 1439
crashtracking [candidate] (1.425 ms) : 0, 1425
BytebuddyAgent [baseline] (732.664 ms) : 0, 732664
BytebuddyAgent [candidate] (731.234 ms) : 0, 731234
GlobalTracer [baseline] (222.694 ms) : 0, 222694
GlobalTracer [candidate] (221.818 ms) : 0, 221818
AppSec [baseline] (32.257 ms) : 0, 32257
AppSec [candidate] (32.226 ms) : 0, 32226
Debugger [baseline] (62.912 ms) : 0, 62912
Debugger [candidate] (63.225 ms) : 0, 63225
Remote Config [baseline] (657.051 µs) : 0, 657
Remote Config [candidate] (643.31 µs) : 0, 643
Telemetry [baseline] (8.118 ms) : 0, 8118
Telemetry [candidate] (7.949 ms) : 0, 7949
Flare Poller [baseline] (3.74 ms) : 0, 3740
Flare Poller [candidate] (3.74 ms) : 0, 3740
ProfilingAgent [baseline] (96.992 ms) : 0, 96992
ProfilingAgent [candidate] (97.278 ms) : 0, 97278
Profiling [baseline] (97.592 ms) : 0, 97592
Profiling [candidate] (97.849 ms) : 0, 97849
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 20 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~e18ea8f5f7, baseline=1.56.0-SNAPSHOT~fb40abaeee
dateFormat X
axisFormat %s
section baseline
no_agent (18.169 ms) : 17988, 18350
. : milestone, 18169,
appsec (18.763 ms) : 18573, 18952
. : milestone, 18763,
code_origins (17.931 ms) : 17756, 18107
. : milestone, 17931,
iast (17.923 ms) : 17745, 18101
. : milestone, 17923,
profiling (18.683 ms) : 18494, 18872
. : milestone, 18683,
tracing (17.799 ms) : 17620, 17978
. : milestone, 17799,
section candidate
no_agent (18.181 ms) : 17995, 18367
. : milestone, 18181,
appsec (18.705 ms) : 18513, 18897
. : milestone, 18705,
code_origins (17.707 ms) : 17532, 17883
. : milestone, 17707,
iast (17.598 ms) : 17422, 17773
. : milestone, 17598,
profiling (18.763 ms) : 18573, 18953
. : milestone, 18763,
tracing (17.823 ms) : 17647, 17999
. : milestone, 17823,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~e18ea8f5f7, baseline=1.56.0-SNAPSHOT~fb40abaeee
dateFormat X
axisFormat %s
section baseline
no_agent (1.208 ms) : 1195, 1220
. : milestone, 1208,
iast (3.35 ms) : 3278, 3423
. : milestone, 3350,
iast_FULL (5.868 ms) : 5809, 5927
. : milestone, 5868,
iast_GLOBAL (3.583 ms) : 3533, 3632
. : milestone, 3583,
profiling (1.928 ms) : 1912, 1943
. : milestone, 1928,
tracing (1.833 ms) : 1818, 1847
. : milestone, 1833,
section candidate
no_agent (1.223 ms) : 1211, 1236
. : milestone, 1223,
iast (3.288 ms) : 3242, 3335
. : milestone, 3288,
iast_FULL (5.888 ms) : 5754, 6022
. : milestone, 5888,
iast_GLOBAL (3.764 ms) : 3714, 3815
. : milestone, 3764,
profiling (2.076 ms) : 2059, 2094
. : milestone, 2076,
tracing (1.808 ms) : 1792, 1823
. : milestone, 1808,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~e18ea8f5f7, baseline=1.56.0-SNAPSHOT~fb40abaeee
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.659 ms) : 3444, 3874
. : milestone, 3659,
iast (2.218 ms) : 2155, 2282
. : milestone, 2218,
iast_GLOBAL (2.254 ms) : 2190, 2318
. : milestone, 2254,
profiling (2.065 ms) : 2013, 2116
. : milestone, 2065,
tracing (2.041 ms) : 1991, 2091
. : milestone, 2041,
section candidate
no_agent (1.486 ms) : 1474, 1497
. : milestone, 1486,
appsec (3.659 ms) : 3447, 3870
. : milestone, 3659,
iast (2.206 ms) : 2143, 2270
. : milestone, 2206,
iast_GLOBAL (2.249 ms) : 2185, 2313
. : milestone, 2249,
profiling (2.448 ms) : 2284, 2613
. : milestone, 2448,
tracing (2.031 ms) : 1982, 2081
. : milestone, 2031,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~e18ea8f5f7, baseline=1.56.0-SNAPSHOT~fb40abaeee
dateFormat X
axisFormat %s
section baseline
no_agent (15.083 s) : 15083000, 15083000
. : milestone, 15083000,
appsec (15.132 s) : 15132000, 15132000
. : milestone, 15132000,
iast (18.978 s) : 18978000, 18978000
. : milestone, 18978000,
iast_GLOBAL (18.133 s) : 18133000, 18133000
. : milestone, 18133000,
profiling (14.876 s) : 14876000, 14876000
. : milestone, 14876000,
tracing (14.582 s) : 14582000, 14582000
. : milestone, 14582000,
section candidate
no_agent (15.218 s) : 15218000, 15218000
. : milestone, 15218000,
appsec (14.437 s) : 14437000, 14437000
. : milestone, 14437000,
iast (18.172 s) : 18172000, 18172000
. : milestone, 18172000,
iast_GLOBAL (17.735 s) : 17735000, 17735000
. : milestone, 17735000,
profiling (14.749 s) : 14749000, 14749000
. : milestone, 14749000,
tracing (14.77 s) : 14770000, 14770000
. : milestone, 14770000,
|
What Does This Do
ClassNameTrieis now part of https://github.com/DataDog/dd-instrument-javaMotivation
Remove duplicate class.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]