Skip to content

Conversation

@lucia-sb
Copy link
Contributor

What does this PR do?

This PR makes it mandatory to specify a commit when running the ddev size status command to send metrics to Datadog. This ensures that all metrics reported are accurately attributed to the intended commit.

Motivation

Previously, the ddev size status command implicitly used the latest commit on the branch to determine which commit the size metrics belonged to. Because the workflow must wait for dependency resolution and new commits may appear during that time the reported sizes could end up being attributed to a newer commit instead of the one that triggered the workflow.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@github-actions
Copy link

⚠️ Recommendation: Add qa/skip-qa label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

@lucia-sb lucia-sb added the qa/skip-qa Automatically skip this PR for the next QA label Nov 27, 2025
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.18%. Comparing base (93a4763) to head (c625b52).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@AAraKKe AAraKKe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lucia, small couple of comments!

My Feedback Legend

Here's a quick guide to the prefixes I use in my comments:

praise: no action needed, just celebrate!
note: just a comment/information, no need to take any action.
question: I need clarification or I'm seeking to understand your approach.
nit: A minor, non-blocking issue (e.g., style, typo). Feel free to ignore.
suggestion: I'm proposing an improvement. This is optional but recommended.
request: A change I believe is necessary before this can be merged.

The only blocking comments are request, any other type of comment can be applied at discretion of the developer.

@datadog-official
Copy link
Contributor

⚠️ Tests

⚠️ Warnings

❄️ 1 New flaky test detected

test_regex_consumer_groups[All consumer offsets, no topics] from test_integration.py (Datadog)

Traceback (most recent call last):
  File "/home/runner/work/integrations-core/integrations-core/kafka_consumer/datadog_checks/kafka_consumer/kafka_consumer.py", line 54, in check
    self.client.request_metadata_update()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/home/runner/work/integrations-core/integrations-core/kafka_consumer/datadog_checks/kafka_consumer/client.py", line 150, in request_metadata_update
    self._cluster_metadata = self.kafka_client.list_topics(None, timeout=self.config._request_timeout)
                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/.local/share/hatch/env/virtual/datadog-kafka-consumer/7tWZBCjR/py3.13-3.3-kerberos/lib/python3.13/site-packages/confluent_kafka/admin/__init__.py", line 639, in list_topics
    return super(AdminClient, self).list_topics(*args, **kwargs)
...

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c625b52 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@lucia-sb lucia-sb added this pull request to the merge queue Dec 3, 2025
Merged via the queue into master with commit 90eabee Dec 3, 2025
331 of 332 checks passed
@lucia-sb lucia-sb deleted the lucia-sb/fix-commit-timestamp branch December 3, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ddev qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants