-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix commit attribution in ddev size status #21993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
AAraKKe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Lucia, small couple of comments!
My Feedback Legend
Here's a quick guide to the prefixes I use in my comments:
praise: no action needed, just celebrate!
note: just a comment/information, no need to take any action.
question: I need clarification or I'm seeking to understand your approach.
nit: A minor, non-blocking issue (e.g., style, typo). Feel free to ignore.
suggestion: I'm proposing an improvement. This is optional but recommended.
request: A change I believe is necessary before this can be merged.
The only blocking comments are request, any other type of comment can be applied at discretion of the developer.
Co-authored-by: Juanpe Araque <[email protected]>
|
What does this PR do?
This PR makes it mandatory to specify a commit when running the
ddev size statuscommand to send metrics to Datadog. This ensures that all metrics reported are accurately attributed to the intended commit.Motivation
Previously, the
ddev size statuscommand implicitly used the latest commit on the branch to determine which commit the size metrics belonged to. Because the workflow must wait for dependency resolution and new commits may appear during that time the reported sizes could end up being attributed to a newer commit instead of the one that triggered the workflow.Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged