Added function to clean data in management column#2
Added function to clean data in management column#2shubhanshu-gupta wants to merge 1 commit intomasterfrom
Conversation
whatevergeek
left a comment
There was a problem hiding this comment.
hi @shubhanshu-gupta ,
thanks for the PR.
are you able to to modify the code to just have the following function signature?
def clean_col_management(input_data):
"""
Clean values in column: "status"
Trello card: https://trello.com/c/HHzNs0hS/1-column-countryname
"""
cleaned_data = input_data
do some cleanin on cleaned_data
return cleaned_data
it's interesting to provide filenames when calling from commandline.
on the otherhand, for testing, we shouldn't be calling this file directly.
we should be calling it from test_clean_wpdx_sample_data.py
speaking of which, can you also submit your updated test_clean_wpdx_sample_data.py file?
this should contain a test function that tests your clean_col_management function
thanks for your help on this.
feel free to let me know if you have further clarifications :-)
|
sorry for the bold... it should be a comment... i think github translated the python comment into markdown bold :-P |
|
hi @shubhanshu-gupta , have a great day! |
No description provided.