Cleans column Count, returns either an integer or None#5
Open
sbtr1 wants to merge 1 commit intoDataKind-SG:masterfrom
Open
Cleans column Count, returns either an integer or None#5sbtr1 wants to merge 1 commit intoDataKind-SG:masterfrom
sbtr1 wants to merge 1 commit intoDataKind-SG:masterfrom
Conversation
whatevergeek
requested changes
Nov 28, 2018
Collaborator
whatevergeek
left a comment
whatevergeek
left a comment
There was a problem hiding this comment.
hi @sbtr1 ,
thanks for helping on this.
please find my review comments below:
I've run the tests and it works. However, please consider the following minor changes and let me know once you have them applied:
file: data_cleaning/clean_wpdx_sample_data.py
- in the clean_col_count function, please update the documentation comment to point to the correct card. It currently points to: https://trello.com/c/HHzNs0hS/1-column-countryname
file: data_cleaning/test_clean_wpdx_sample_data.py - in the test_clean_col_count function, please update the documentation comment to refer to "col_count". Currently, it says "country_name".
- Apart from the negative case. e.g. assert clean_wpdx_sample_data.clean_col_count('123') == 123
Feel free to let me know if there's any clarification.
Thanks again for the help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.