feat: enhance database deduplication with symlink support#336
Merged
MaatheusGois merged 1 commit intoDebugSwift:mainfrom Apr 13, 2026
Merged
Conversation
… encapsulation - Added support for resolving symbolic links using resolvingSymlinksInPath() to ensure accurate deduplication of database files. - Encapsulated deduplicateDatabaseFiles as a private implementation detail. - Introduced a new integration test suite to verify the deduplication logic in a real iOS Simulator environment.
xinnjie
force-pushed
the
feature/private-deduplicate-database-files
branch
from
d3d9f46 to
1a8b95b
Compare
xinnjie
changed the title
ExampleTests.xctest: Coverage: 96.96
Generated by 🚫 Danger Swift against 1a8b95b |
xinnjie
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
resolvingSymlinksInPath()during database file discovery. This ensures that symbolic links and their target files are correctly identified as duplicates.DatabaseFileManagerTests.swift) that creates real files and symbolic links in the iOS Simulator's directories to verify the deduplication logic indirectly.Verification
xcodebuild.discoverDatabaseFiles()properly deduplicates files even when different paths (symbolic links) point to the same physical file.Before:
After:
