Conversation
4jd37g symlinked to the T20 Omni profile (p1jij8), under which the newer JSON commands (clean_V2, freeClean, area cleaning) fail on the X5 OMNI. Owner-tested in DeebotUniverse#1709: the X5 PRO OMNI (mxse7w) profile works correctly. e6yxdm resolved its T20 profile through the 4jd37g link, so point it at p1jij8 directly to keep its behavior unchanged. Fixes DeebotUniverse#1709 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1744 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 161 161
Lines 6399 6399
Branches 368 368
=======================================
Hits 6160 6160
Misses 172 172
Partials 67 67 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The DEEBOT X5 OMNI (model id
4jd37g) is symlinked to the T20 Omni profile (p1jij8.py). Under that profile the newer JSON API commands fail on this model —clean_V2,freeCleanand area cleaning don't work (#1709).Fix
4jd37g.pysymlink at the X5 PRO OMNI profile (mxse7w.py). The reporter of DEEBOT X5 OMNI (model_id 4jd37g) mapped to wrong T20 Omni capabilities #1709 tested exactly this swap on their X5 OMNI (firmware 1.74.0) and confirmed the device works correctly, includingclean_V2,freeCleanand area cleaning.e6yxdm.pyused to resolve its T20 profile through the4jd37glink — it now points atp1jij8.pydirectly, so its behavior is unchanged.Testing
pytest tests/hardware/test_init.py: 7 passed (every model module, including both retargeted symlinks, loads).Fixes #1709