Skip to content

Fix: Suppress expected JIRA validation alerts when pushing (Fixes #12988) #13974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
valentijnscholten wants to merge 4 commits into
base: bugfix
Choose a base branch
from
Open

Fix: Suppress expected JIRA validation alerts when pushing (Fixes #12988) #13974

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4248662
Fix: Suppress expected JIRA validation alerts when auto-pushing
valentijnscholten Dec 23, 2025
bae5d78
Merge branch 'bugfix' into fix/12988-suppress-expected-jira-alerts
valentijnscholten Dec 23, 2025
8c39ebe
fix
valentijnscholten Dec 24, 2025
8a84b82
Update dojo/jira_link/helper.py
valentijnscholten Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions dojo/jira_link/helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -906,13 +906,30 @@ def failure_to_add_message(message: str, exception: Exception, _: Any) -> bool:
message = f"Object {obj.id} cannot be pushed to JIRA as the JIRA instance has been deleted or is not available."
return failure_to_add_message(message, None, obj)

obj_can_be_pushed_to_jira, error_message, _error_code = can_be_pushed_to_jira(obj)
obj_can_be_pushed_to_jira, error_message, error_code = can_be_pushed_to_jira(obj)
if not obj_can_be_pushed_to_jira:
# Expected validation failures (not verified, not active, below threshold)
# should not create alerts when auto-pushing via "push all issues"
# These are expected conditions that don't indicate a problem
expected_validation_errors = [
"error_not_active_or_verified",
"error_below_minimum_threshold",
"error_empty",
"error_inactive",
]

# not sure why this check is not part of can_be_pushed_to_jira, but afraid to change it
if isinstance(obj, Finding) and obj.duplicate and not obj.active:
logger.warning("%s will not be pushed to JIRA as it's a duplicate finding", to_str_typed(obj))
log_jira_cannot_be_pushed_reason(error_message + " and findis a duplicate", obj)
logger.info("%s will not be pushed to JIRA as it's a duplicate finding", to_str_typed(obj))
# Duplicates are expected, don't create alerts
logger.info("%s cannot be pushed to JIRA: %s (expected - duplicate finding)",
to_str_typed(obj), error_message)
elif error_code in expected_validation_errors:
# These are expected when auto-pushing, only log, don't alert
logger.info("%s cannot be pushed to JIRA: %s (expected - finding not ready yet)",
to_str_typed(obj), error_message)
else:
# Unexpected errors (configuration issues, etc.) should still alert
log_jira_cannot_be_pushed_reason(error_message, obj)
logger.warning("%s cannot be pushed to JIRA: %s.", to_str_typed(obj), error_message)
logger.warning("The JIRA issue will NOT be created.")
Expand Down
Loading