Fix confused-deputy broker bypass (C1) + authenticate the approval endpoint (C2)#3
Merged
Merged
Conversation
…dpoint (C2) C1: the broker reconstructs the outbound URL from the authorized action and no longer forwards an agent-supplied query not in params. C2: the human-approval endpoints now require DELEGO_APPROVAL_TOKEN, a trust domain separate from the agent-facing /propose & /resolve, so a compromised agent can't approve its own actions. Adds tests/test_approval_auth.py. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fixes in the reference integration (7 tests pass).
paramsis dropped/refused (spec §4.2).DELEGO_APPROVAL_TOKEN, separate from the agent surface — the human-in-the-loop gate can no longer be self-approved by the agent.🤖 Generated with Claude Code