Skip to content

Conversation

@thomas-pijls
Copy link
Contributor

What was done

The goal was to keep the (not used) layertypes 3 and 4 in the code, but to clarify their definition and make them private (i.e. remove all reference to these layertypes from public sources such as the User Manual). This was achieved by:

  • Layertypes 3 (polygon controlled z-layers) and 4 (density controlled sigma-layers) definitions were clarified
  • The layertype 3 and 4 descriptions were updated in all files
  • Layertype 3 and 4 specific variables/keywords (VertplizFile, Tsigma, dkx, sdkx) documentation updated
  • VertplizFile and Tsigma mdu keywords were set to deprecated and obsolete, respectively
  • *.mdu files in repo were updated to remove VertplizFile keyword and updated Layertype description
  • User Manual was updated to remove all mention of layertypes 3 and 4 and remove the description of the layertype 3 specific VertplizFile keyword

Evidence of the work done

  • Not applicable

Tests

  • Not applicable

Documentation

  • User manual updated; updated layertype description and removed description of VertplizFile
  • Updated keyword description of Layertype and removed description of VertplizFile and Tsigma descriptions in the D-HYDRO-File-Specifications repo

Issue link

@thomas-pijls thomas-pijls changed the title All/task/unst 9149 cleanup layertype2 UNST-9149: Cleanup layertype v2 Nov 25, 2025
Copy link
Member

@arthurvd arthurvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good work across many files. See my comments (and probably make some more changes in the manual appendix too to be consistent with these suggestions)

@thomas-pijls thomas-pijls merged commit 857204f into main Dec 1, 2025
19 checks passed
@thomas-pijls thomas-pijls deleted the all/task/UNST-9149_cleanup_layertype2 branch December 1, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants