Added two items from #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-horvath-deltares
requested changes
Oct 8, 2025
Contributor
k-horvath-deltares
left a comment
k-horvath-deltares
left a comment
There was a problem hiding this comment.
Could you maybe improve the commit? Add two items from... , and what is their purpose?
There was a problem hiding this comment.
Pull Request Overview
This PR adds power calculation models for hydraulic structures (pump and turbine-generator) and a new multi-IO reservoir component to support the issue RTCTOOLS-943.
Key Changes:
- Added
TurbineGeneratorandPumpPowermodels with power generation/demand calculations - Added
Reservoir_multi_ioto the SimpleRouting package
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/rtctools_channel_flow/modelica/Deltares/ChannelFlow/Hydraulic/Structures/package.order | Added PumpPower and TurbineGenerator to the Structures package order |
| src/rtctools_channel_flow/modelica/Deltares/ChannelFlow/SimpleRouting/Reservoir/package.order | Added Reservoir_multi_io to the Reservoir package order |
| src/rtctools_channel_flow/modelica/Deltares/ChannelFlow/Hydraulic/Structures/TurbineGenerator.mo | New model for turbine-generator power generation calculations |
| src/rtctools_channel_flow/modelica/Deltares/ChannelFlow/Hydraulic/Structures/PumpPower.mo | New model for pump power demand calculations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Real dH; | ||
| equation | ||
| dH = HQUp.H - HQDown.H; | ||
| PowerDemand = Q * 1.0/efficiency * dH *1000; |
There was a problem hiding this comment.
The expression 1.0/efficiency could cause division by zero if efficiency is zero. Consider adding input validation or documenting the assumption that efficiency must be non-zero.
src/rtctools_channel_flow/modelica/Deltares/ChannelFlow/Hydraulic/Structures/PumpPower.mo
Outdated
Show resolved
Hide resolved
...rtctools_channel_flow/modelica/Deltares/ChannelFlow/Hydraulic/Structures/TurbineGenerator.mo
Outdated
Show resolved
Hide resolved
src/rtctools_channel_flow/modelica/Deltares/ChannelFlow/Hydraulic/Structures/PumpPower.mo
Outdated
Show resolved
Hide resolved
…lic/Structures/PumpPower.mo Co-authored-by: Copilot <[email protected]>
…lic/Structures/TurbineGenerator.mo Co-authored-by: Copilot <[email protected]>
…lic/Structures/PumpPower.mo Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issuetracker.deltares.nl/browse/RTCTOOLS-943