Run examples and compile in OM #13
Open
+11
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes lines in PartialHomotopic, and with this change it does not compile in Open Modelica Editor any more.
There are 5 remaining models that do not compile, 4 of them based on partial homotopic and hydrulic structures pum puser equation dh.
… be at least as the maximum point of the channel bed at any point of the channel. This might be slightly restrictive in very steep channels, however, it is rare to have such channels with flows close to supercritical on operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The files are fixed such that the examples are running and they also compile in OM. For partial homotopic an assumption is used that the minimum water level should be at least as big as the largest bottom elevation anywhere in the channel. This might effect the function ranges and thus slightly the scaling. (it will be more conservative)