feat: file store - #460
Merged
Merged
Conversation
While it ought to never occur, ensure images are loaded before GC so we don't blow away all images.
Use the new file store instead of file layer
Verify returned SAF rename matches. Deleting resolves the child without requiring write access.
media_scanner didn't work for SAF locations anyways.
Prevent exception on dispose if panning never happened.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under the hood revamp of the file layer API into a "file store" API. This hides the details of external/internal from callers, allows for testing these critical file operations, and unifies the interface across everything that stores files.