Repository navigation
Fix GitHub login redirect_uri on macOS - #5513
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change correctly preserves the encoded OAuth query without affecting other authentication behavior.
0 open findings
What changed in this PR
Fixes GitHub OAuth login on macOS by preserving URL escaping.
Changes:
- Launches the OAuth URL using
AbsoluteUri. - Documents why
ToString()corruptsredirect_uri.
| File | Description |
|---|---|
src/UniGetUI.Avalonia/Infrastructure/GitHubAuthService.cs |
Preserves OAuth URL escaping when opening the browser. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![randy-but-a-ro[bot]](https://avatars.githubusercontent.com/in/113084?s=60&v=4){kind=small}
There was a problem hiding this comment.
🤖 Pull request was approved automatically: the AI review is complete and all its review threads are resolved. 🎉
Integration Details
{
"deliveryId": "60c5d240-c734-11f1-9bb3-a1a128780281",
"headSha": "82e12dfe90c3e3874b019b44f3af2210ae87f4e6",
"reviewer": "copilot-pull-request-reviewer[bot]"
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue with how the OAuth login URL is launched during the GitHub authentication process. The change ensures that the URL is correctly formatted to prevent issues with macOS re-escaping characters, which could corrupt the
redirect_uriparameter.Authentication flow fix:
SignInAsyncinGitHubAuthService.csto useoauthLoginUrl.AbsoluteUriinstead ofToString()when launching the OAuth login URL, preventing macOS from corrupting theredirect_uriwith double-escaping.